englebass pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=8b72bd6e6d4aab3439eb4558c4a5776e17651f94

commit 8b72bd6e6d4aab3439eb4558c4a5776e17651f94
Author: Sebastian Dransfeld <s...@tango.flipp.net>
Date:   Sat Dec 7 18:25:22 2013 +0100

    ecore_x: Fix bug in ecore_x_region_invert
    
    As bounds is a pointer, bounds + num will always be postive, so this is
    an eternal loop. In addition, XFixesInvertRegion only accepts one
    region, so num must be 1.
    
    Fixes CID 1039469
---
 src/lib/ecore_x/xlib/ecore_x_fixes.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/lib/ecore_x/xlib/ecore_x_fixes.c 
b/src/lib/ecore_x/xlib/ecore_x_fixes.c
index b647a90..0e7aa1f 100644
--- a/src/lib/ecore_x/xlib/ecore_x_fixes.c
+++ b/src/lib/ecore_x/xlib/ecore_x_fixes.c
@@ -259,11 +259,9 @@ ecore_x_region_invert(Ecore_X_Region dest,
 {
 #ifdef ECORE_XFIXES
    XRectangle *xbound;
-   int num = 0;
+   int num = 1;
 
    LOGFN(__FILE__, __LINE__, __FUNCTION__);
-   while (bounds + num)
-     num++;
    xbound = _ecore_x_rectangle_ecore_to_x(bounds, num);
 
    XFixesInvertRegion(_ecore_x_disp, dest, xbound, source);

-- 


Reply via email to