On Fri, Dec 13, 2013 at 2:40 AM, Michael Blumenkrantz < michael.blumenkra...@gmail.com> wrote:
> On Thu, 12 Dec 2013 09:38:03 -0800 > Daniel Juyung Seo <seojuyu...@gmail.com> wrote: > > > seoz pushed a commit to branch master. > > > > > http://git.enlightenment.org/tools/enventor.git/commit/?id=27cb2ab4e736f1d4ca7cca80eed3f93c332f85d2 > > > > commit 27cb2ab4e736f1d4ca7cca80eed3f93c332f85d2 > > Author: Daniel Juyung Seo <seojuyu...@gmail.com> > > Date: Fri Dec 13 02:30:44 2013 +0900 > > > > enventor - use eina_stringshare_replace instead of > eina_stringshare_add > > + del. > > --- > > src/bin/menu.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/src/bin/menu.c b/src/bin/menu.c > > index 0d484d8..d0f368c 100644 > > --- a/src/bin/menu.c > > +++ b/src/bin/menu.c > > @@ -738,9 +738,8 @@ fileselector_save_done_cb(void *data, Evas_Object > *obj, void *event_info) > > menu_data *md = data; > > const char *selected = event_info; > > > > - if (md->last_accessed_path) > > - eina_stringshare_del(md->last_accessed_path); > > - md->last_accessed_path = > eina_stringshare_add(elm_fileselector_path_get(obj)); > > + eina_stringshare_replace(&(md->last_accessed_path), > > + elm_fileselector_path_get(obj)); > > > > if (!selected) > > { > > @@ -806,9 +805,8 @@ fileselector_load_done_cb(void *data, Evas_Object > *obj, void *event_info) > > menu_data *md = data; > > const char *selected = event_info; > > > > - if (md->last_accessed_path) > > - eina_stringshare_del(md->last_accessed_path); > > - md->last_accessed_path = > eina_stringshare_add(elm_fileselector_path_get(obj)); > > + eina_stringshare_replace(&(md->last_accessed_path), > > + elm_fileselector_path_get(obj)); > > > > if (!selected) > > { > > > > you can actually use the new eina_stringshare_refplace function from 1.8 > here, which works when both strings are stringshared. > > That's a nice suggestion. I actually checked refplace function before I commit but I wasn't sure if elm_fileselector_path_get() returns stringshare. Now I checked it uses stringshare and enventor depends on efl 1.8, it looks ok to go. Thanks a lot! Daniel Juyung Seo (SeoZ) > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics > Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
