On Thu, 19 Dec 2013 22:11:37 -0800 Cedric BAIL <[email protected]> wrote:
> cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=1929637aa0c12f6d2bd2a09e218fba736965a238 > > commit 1929637aa0c12f6d2bd2a09e218fba736965a238 > Author: Cedric BAIL <[email protected]> > Date: Fri Dec 20 14:39:57 2013 +0900 > > evas: no loader should ever close an Eina_File anymore. > > This would lead to some crash in EFM if relying on Evas to find the file > format by > trying all its loader. > > This should fix T674 and T668. it seems at this point that eina_file_close() is the gift that keeps on giving. > --- > src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c > b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c > index 50d1226..0a15181 100644 > --- a/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c > +++ b/src/modules/evas/loaders/pmaps/evas_image_load_pmaps.c > @@ -170,8 +170,6 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f, > Eina_Bool header, int *error) > if (!b->map) > { > *error = EVAS_LOAD_ERROR_DOES_NOT_EXIST; > - eina_file_close(b->file); > - b->file = NULL; > return EINA_FALSE; > } > > @@ -187,9 +185,7 @@ pmaps_buffer_open(Pmaps_Buffer *b, Eina_File *f, > Eina_Bool header, int *error) > { > *error = EVAS_LOAD_ERROR_CORRUPT_FILE; > eina_file_map_free(b->file, b->map); > - eina_file_close(b->file); > b->map = NULL; > - b->file = NULL; > return EINA_FALSE; > } > > stefan's going to kill me for this but...it needs to get into the next minor release pretty urgently :/ ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
