On 31/12/13 13:48, daniel.za...@samsung.com wrote: > On 12/31/2013 03:30 PM, Tom Hacohen wrote: >> tasn pushed a commit to branch master. >> >> http://git.enlightenment.org/tools/clouseau.git/commit/?id=bbdcab85c8e9050fbb0f4d09df045aec72029ff7 >> >> commit bbdcab85c8e9050fbb0f4d09df045aec72029ff7 >> Author: Tom Hacohen <t...@stosb.com> >> Date: Tue Dec 31 13:22:33 2013 +0000 >> >> Client: Fixed pointer printing. >> --- >> src/bin/clouseau_client.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c >> index 03724f8..dc5aedb 100644 >> --- a/src/bin/clouseau_client.c >> +++ b/src/bin/clouseau_client.c >> @@ -2172,6 +2172,14 @@ _obj_info_gl_item_text_get(void *data, Evas_Object >> *obj EINA_UNUSED, >> else >> snprintf(buf, sizeof(buf), "%s", eo->name); >> } >> + else if (eina_value_type_get(&(eo->value)) == EINA_VALUE_TYPE_UINT64) >> + { >> + /* We treat UINT64 as a pointer. */ >> + >> + uint64_t ptr = NULL; >> + eina_value_get(&(eo->value), &ptr); >> + snprintf(buf, sizeof(buf), "%s: %p", eo->name, (void *) (uintptr_t) >> ptr); >> + } > Just for curiosity, why do you need to cast twice? (void *) is not > sufficient?
Curiosity killed the cat. Actually, looking at it, this code is wrong. It should not use %p, because the client might run on a 32bit system while inspecting a 64bit one. The reason for the double cast is that you usually get warnings if you past to/from a pointer to/from an integer of a different size. So in this case, without the double-cast you'd get warnings on a 32bit system. -- Tom. ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
