So fix elm_widget_mirrored_set. Or heck, even add an elm_widget_mirrored_lazy_load_set function that does that variable setting you were doing there in code (although it's preferred to fix mirrored_set).
"If you worry about the future change. then we can make it at that time." That's exactly how bad codebase and a buggy mess is created. Sure, one shouldn't over-engineer and try to think of every future scenario (that would actually be bad), but doing the basics, like not accessing a class's private data in a way it wouldn't expect is not over-engineering and over-future-proofing. -- Tom. On 07/01/14 03:05, ChunEon Park wrote: > Ok, already comment mentioned. > > We should not call the theme_hook() while the smart data is created. > If so, each theme_hook() should care the datas that are initialized or not. > actually no need to call the theme_hook() in the smart_add time. since it > won't intialize anything yet. > > But elm_widget_mirrored_set() calls elm_widget_theme() internally. it will > cause the above problem. > > -----Original Message----- > From: "ChunEon Park"<her...@naver.com> > To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2014-01-07 (화) 11:54:25 > Subject: Re: [E-devel][EGIT] [core/elementary] master 01/01: [elm_widget] Fix > not to load theme for mirroring if smart data is not set > > Is it problem at this moment? > > The current is simpler than before. > I don't agree on you. > > If you worry about the future change. > then we can make it at that time. > > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Tom Hacohen"<tom.hacohen>@samsung.com> > To: "Enlightenment developer > list"<enlightenment-devel>@lists.sourceforge.net>; > Cc: > Sent: 2014-01-07 (화) 02:03:58 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: [elm_widget] > Fix not to load theme for mirroring if smart data is not set > > On 31/12/13 12:41, Tom Hacohen wrote: >> On 31/12/13 11:33, Jaehyun Cho wrote: >>> - elm_widget_mirrored_set(obj, elm_config_mirrored_get()); >>> + priv->is_mirrored = elm_config_mirrored_get(); >> >> This looks very wrong and bad practice. What happens if I'll change >> elm_widget_mirrored_set()? Things will break... Unless you have a really >> good reason for doing that (which you don't, there's no good reason). I >> suggest this patch will be amended. > > Any updates? Or should I just revert this patch? > > -- > Tom. > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
