On Thu, 9 Jan 2014 09:51:45 +0900 Cedric BAIL <cedric.b...@free.fr> said:
i don't know if this is it... but i am doing my morning email rounds and redbuilds... and now edje_cc is segving. terminology can't even start... and i only got as far as rebuilding efl. elm build fails in edje_cc... something.. somewhere... is fucked up. and it happened in the last 8hrs or so. > On Thu, Jan 9, 2014 at 9:10 AM, Jihoon Kim <imfin...@gmail.com> wrote: > > jihoon pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=955cc579d4d0b52cc71e309c35d1850424dc3cca > > > > commit 955cc579d4d0b52cc71e309c35d1850424dc3cca > > Author: Jihoon Kim <jihoon48....@samsung.com> > > Date: Thu Jan 9 09:08:32 2014 +0900 > > > > fix allocator sizeof operand mismatch reported by clang > > > > > > https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-07-1/report-QL6MiM.html#EndPath > > > > https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-07-1/report-a2l0Ci.html#EndPath > > > > https://build.enlightenment.org/job/nightly_efl_clang_x86_64/lastSuccessfulBuild/artifact/scan-build/build/2014-01-07-1/report-McvqNf.html#EndPath > > --- > > src/lib/ecore_file/ecore_file_monitor_inotify.c | 2 +- > > src/lib/eina/eina_tiler.c | 2 +- > > src/lib/evas/common/evas_tiler.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/lib/ecore_file/ecore_file_monitor_inotify.c > > b/src/lib/ecore_file/ecore_file_monitor_inotify.c index e21e41c..2c40087 > > 100644 > > --- a/src/lib/ecore_file/ecore_file_monitor_inotify.c > > +++ b/src/lib/ecore_file/ecore_file_monitor_inotify.c > > @@ -114,7 +114,7 @@ ecore_file_monitor_backend_add(const char *path, > > ecore_file_monitor_backend_init(); > > } > > > > - em = (Ecore_File_Monitor *)calloc(1, sizeof > > (Ecore_File_Monitor_Inotify)); > > + em = (Ecore_File_Monitor *)calloc(1, sizeof(Ecore_File_Monitor)); > > if (!em) return NULL; > > > > em->func = func; > > diff --git a/src/lib/eina/eina_tiler.c b/src/lib/eina/eina_tiler.c > > index 0301737..bffa66b 100644 > > --- a/src/lib/eina/eina_tiler.c > > +++ b/src/lib/eina/eina_tiler.c > > @@ -167,7 +167,7 @@ rect_list_node_pool_get(void) > > return node; > > } > > else > > - return malloc(sizeof(rect_node_t)); > > + return malloc(sizeof(list_node_t)); > > } > > This one and the one bellow are wrong, for sure. Give a closer look at > the code and you will see that even if we return a list_node_t, the > underlying code is going at somepoint to use a rect_node_t (who start > with a list_node_t). It is a bad things that we have this duplicated > logic for list, but it is correct. Could your partially revert your > patch and maybe add a documentation so that nobody else fall in the > same trap ? > > > diff --git a/src/lib/evas/common/evas_tiler.c > > b/src/lib/evas/common/evas_tiler.c index fd6c65a..bf2a590 100644 > > --- a/src/lib/evas/common/evas_tiler.c > > +++ b/src/lib/evas/common/evas_tiler.c > > @@ -72,7 +72,7 @@ rect_list_node_pool_get(void) > > list_node_pool.len--; > > return node; > > } > > - else return (list_node_t *)malloc(sizeof(rect_node_t)); > > + else return (list_node_t *)malloc(sizeof(list_node_t)); > > } > > > > static inline void > > Thanks, > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
