ryuan pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=2ab2d561d4a5e4ad129fce7da3c519d5d2dec877

commit 2ab2d561d4a5e4ad129fce7da3c519d5d2dec877
Author: Ryuan Choi <[email protected]>
Date:   Fri Jan 10 21:05:00 2014 +0900

    genlist: Check return value out of the loop in _realized_items_get
---
 src/lib/elm_genlist.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index f7d9788..b6d0be3 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -5952,7 +5952,9 @@ _realized_items_get(Eo *obj EINA_UNUSED, void *_pd, 
va_list *list)
 
    Eina_List **ret = va_arg(*list, Eina_List **);
    Elm_Genlist_Smart_Data *sd = _pd;
-   if (ret) *ret = NULL;
+   if (!ret) return;
+
+   *ret = NULL;
 
    EINA_INLIST_FOREACH(sd->blocks, itb)
      {
@@ -5964,7 +5966,7 @@ _realized_items_get(Eo *obj EINA_UNUSED, void *_pd, 
va_list *list)
              done = EINA_TRUE;
              EINA_LIST_FOREACH(itb->items, l, it)
                {
-                  if (it->realized && ret) *ret = eina_list_append(*ret, it);
+                  if (it->realized) *ret = eina_list_append(*ret, it);
                }
           }
         else

-- 


Reply via email to