[EGIT] [enlightenment/modules/penguins] master 01/05: Add -Wall to compiler flags and remove all remaining warnings

[davemds]

davemds pushed a commit to branch master.

http://git.enlightenment.org/enlightenment/modules/penguins.git/commit/?id=90199b9fa7e724ae0adf0a793b09d58e71df57f3

commit 90199b9fa7e724ae0adf0a793b09d58e71df57f3
Author: davemds <d...@gurumeditation.it>
Date:   Mon Jan 20 23:34:04 2014 +0100

    Add -Wall to compiler flags and remove all remaining warnings
---
 src/Makefile.am      | 9 +++++----
 src/e_mod_main.c     | 2 +-
 src/e_mod_penguins.c | 4 ++--
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index cef601b..62c5e1e 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -1,9 +1,10 @@
 MAINTAINERCLEANFILES = Makefile.in
 
-INCLUDES = -I. \
-           -I$(top_srcdir) \
-           -I$(includedir) \
-           @E_CFLAGS@
+AM_CPPFLAGS = -Wall \
+              -I. \
+              -I$(top_srcdir) \
+              -I$(includedir) \
+              @E_CFLAGS@
 
 pkgdir = $(datadir)/$(MODULE_ARCH)
 pkg_LTLIBRARIES = module.la
diff --git a/src/e_mod_main.c b/src/e_mod_main.c
index 1937338..dab7e6e 100644
--- a/src/e_mod_main.c
+++ b/src/e_mod_main.c
@@ -42,7 +42,7 @@ e_modapi_shutdown(E_Module *m)
    e_configure_registry_item_del("appearance/penguins");
    e_configure_registry_category_del("appearance");
 
-   if (pop = m->data)
+   if ((pop = m->data))
    {
       E_FREE_FUNC(pop->config_dialog, e_object_del);
       penguins_shutdown(pop);
diff --git a/src/e_mod_penguins.c b/src/e_mod_penguins.c
index aebc9f2..23cc246 100644
--- a/src/e_mod_penguins.c
+++ b/src/e_mod_penguins.c
@@ -60,7 +60,6 @@ Penguins_Population *
 penguins_init(E_Module *m)
 {
    Penguins_Population *pop;
-   Eina_List *managers, *l, *l2;
    char buf[PATH_MAX];
 
    pop = E_NEW(Penguins_Population, 1);
@@ -106,10 +105,11 @@ penguins_init(E_Module *m)
       if (eina_str_has_suffix(filename, ".edj"))
       {
          snprintf(buf, sizeof(buf), "%s/themes/%s", e_module_dir_get(m), 
filename);
-         if (name = edje_file_data_get(buf, "PopulationName"))
+         if ((name = edje_file_data_get(buf, "PopulationName")))
          {
             printf("PENGUINS: Theme found: %s (%s)\n", filename, name);
             pop->themes = eina_list_append(pop->themes, strdup(buf));
+            free(name);
          }
       }
       free(filename);

--