On Wed, 29 Jan 2014 16:01:10 -0800 Carsten Haitzler <ras...@rasterman.com> wrote:
> raster pushed a commit to branch master. > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=83397e1bde51830016e9a0f8e6482fc91bb4c50c > > commit 83397e1bde51830016e9a0f8e6482fc91bb4c50c > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > Date: Thu Jan 30 08:55:28 2014 +0900 > > fix segv where comp_data is null but still accessed > > it seems i have an override-redirect window just off the bottom-right > of my screen - i think its the scim input panel status. what happens > is it is "managed" by comp but then deleted (_e_comp_x_hook_client_del > called), BUT _e_comp_x_object_add is called with a deferred event for > that client to add it again (likely this is a race) which finds he > client in a state of not having comp_data as the E_FREE in > _e_comp_x_hook_client_del() frees it and sets it to NULL. move the > comp_data free to the actual client free (which is the last time a > client is valid at all) solves this. > --- > src/bin/e_client.c | 1 + > src/bin/e_comp_x.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > I guess I'll have to take a look at this. Freeing comp_data in _e_client_free() is wrong in all cases since it's compositor-specific and guarantees that data will leak. ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
