Hello. On Fri, 2014-02-14 at 00:35, Sung W. Park wrote: > sung pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=2b4a7b438def96d01a5c0bb85d2c9636773d333d > > commit 2b4a7b438def96d01a5c0bb85d2c9636773d333d > Author: Sung W. Park <sung...@gmail.com> > Date: Sat Feb 15 02:33:47 2014 +0900 > > evas gl: added partial rendering support for qcom extension > > When running in direct rendering mode, properly support partial > rendering if the extension is properly supported. > > Also, fixed the SwapBufferwWithDamage rectangle coordinate bug. > It wasn't properly y-inverted before. > --- > src/modules/evas/engines/gl_common/evas_gl_api.c | 28 ++++- > .../evas/engines/gl_common/evas_gl_common.h | 9 +- > .../evas/engines/gl_common/evas_gl_context.c | 58 +++++++-- > src/modules/evas/engines/gl_common/evas_gl_core.c | 132 > +++++++++++++++++++-- > src/modules/evas/engines/gl_common/evas_gl_core.h | 13 +- > .../evas/engines/gl_common/evas_gl_core_private.h | 10 +- > src/modules/evas/engines/gl_x11/evas_engine.c | 86 ++++++++++---- > src/modules/evas/engines/wayland_egl/evas_engine.c | 14 ++- > 8 files changed, 298 insertions(+), 52 deletions(-)
After reading through the whole backlog of commits that happened over the last week this commit jumps out. It hit git 5 days after the merge window closed. While the commit message mentions that this also fixes a bug it clearly describes a new feature added. Partial rendering support. What worries me most is that it touches core code in the evas gl engine. Did you realize that that we have been in a stabilization phase which would exclude new features? If yes, why did you decide to put it in? Its a candidate for reverting for me but I want to seek some opinions first. regards Stefan Schmidt ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
