Hello.
On Fri, 2014-02-21 at 00:56, Cedric BAIL wrote:
> cedric pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=12a0cc8342328e3246021aaad4ca938b93f6a259
>
> commit 12a0cc8342328e3246021aaad4ca938b93f6a259
> Author: Cedric BAIL <cedric.b...@samsung.com>
> Date: Fri Feb 21 17:54:17 2014 +0900
>
> autotools: make specifying binary look the same as Elementary.
We had a ticket number on phab for this, right?
> ---
> configure.ac | 6 ++++++
> m4/efl_binary.m4 | 4 ++--
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 8c6193d..3ef01b0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -4128,6 +4128,12 @@ echo " CPPFLAGS......: $CPPFLAGS"
> echo " CFLAGS........: $CFLAGS"
> echo " CXXFLAGS......: $CXXFLAGS"
> echo " LDFLAGS.......: $LDFLAGS"
> +
> +if test "x${with_binary_edje_cc}" != "x"; then
> +echo " edje_cc.......: ${with_binary_edje_cc}"
> +fi
> +
> +echo " "
> echo "Installation....: make install (as root if needed, with 'su' or
> 'sudo')"
> echo " prefix........: $prefix"
> echo
> diff --git a/m4/efl_binary.m4 b/m4/efl_binary.m4
> index 2748ea1..2d0aea7 100644
> --- a/m4/efl_binary.m4
> +++ b/m4/efl_binary.m4
> @@ -10,8 +10,8 @@ m4_pushdef([DOWN], m4_translit([[$2]], [-A-Z], [_a-z]))dnl
> m4_pushdef([UP], m4_translit([[$2]], [-a-z], [_A-Z]))dnl
> dnl configure option
>
> -AC_ARG_WITH([bin-$2],
> - [AC_HELP_STRING([--with-bin-$2=PATH], [specify a specific path to ]DOWN[
> @<:@default=]DOWN[@:>@])],
> +AC_ARG_WITH([$2],
> + [AC_HELP_STRING([--with-$2=PATH], [specify a specific path to ]DOWN[
> @<:@default=]DOWN[@:>@])],
I can see how it is nice to have it the same wording on efl and elm,
but this happily breaks scripts and other automated things. Maybe
keeping the old syntax around for now, supporting both, and issuing a
warning for the old one in the next release?
regards
Stefan Schmidt
------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121054471&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
