seoz pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=aa9cc88f16be9bb841ffb7e4aa4c6e61cb1b371c

commit aa9cc88f16be9bb841ffb7e4aa4c6e61cb1b371c
Author: Daniel Juyung Seo <seojuyu...@gmail.com>
Date:   Fri Mar 21 00:46:47 2014 +0900

    diskselector: Compare correct variables.
    
    It was comparing the same variable.
    Fixed coverity CID 1193236:  Pointless string comparison
    (CONSTANT_EXPRESSION_RESULT)
    
    @fix
---
 src/lib/elm_diskselector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/elm_diskselector.c b/src/lib/elm_diskselector.c
index 320165e..b641c46 100644
--- a/src/lib/elm_diskselector.c
+++ b/src/lib/elm_diskselector.c
@@ -63,7 +63,7 @@ _selected_item_indicate(Elm_Diskselector_Item *item)
 
    EINA_LIST_FOREACH(sd->r_items, l, it)
      {
-        if (it->label && !strcmp(it->label, it->label))
+        if (it->label && !strcmp(it->label, item->label))
           edje_object_signal_emit(VIEW(it), "elm,state,selected", "elm");
         else
           edje_object_signal_emit(VIEW(it), "elm,state,default", "elm");

-- 


Reply via email to