I reverted my revert, again. I missed this change already pushed in the 1.9 release.
We can prevent abi break at least(since 1.9.1), but cannot prevent api break. If everyone agree on the api break then maybe it's ok to revert this type. But I don't want api break neither this type pushed in :( ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Daniel Juyung Seo"<seojuyu...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: Sent: 2014-03-22 (토) 15:31:36 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: Unbreak the ABI break of window type. Hi On Thu, Mar 13, 2014 at 8:56 AM, Carsten Haitzler <raster>@rasterman.com>wrote: > On Wed, 12 Mar 2014 14:25:57 -0300 Gustavo Sverzut Barbieri > <barbieri>@gmail.com> said: > > > This is basically useless as the point of having unknown as 0 is to get > > uninitialized stuff. Just remove this unknown value. > > i would have to agree. a window will ALWAYS have a known type because it's > set > up at creation. a window can never be unknown... > > UNLESS the object is null or the wrong type. ie it's not a window. if > that's > the case... it's largely irrelevant what is returned - there is nothing > really > sensible you can do with the type - so returning "basic" is as good as > anything. > > Both are correct but can we remove ELM_WIN_UNKNOWN symbol even it was released in 1.9? It will be great if we can clean this up as of now but we already released that symbol :( Daniel Juyung Seo (SeoZ) > > On Tuesday, March 11, 2014, Daniel Juyung Seo <seojuyung2>@gmail.com> > wrote: > > > > > seoz pushed a commit to branch master. > > > > > > > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=79d2df12fe5e4d57d7a6247975feac1f0793ec72 > > > > > > commit 79d2df12fe5e4d57d7a6247975feac1f0793ec72 > > > Author: Daniel Juyung Seo <seojuyung2>@gmail.com <javascript:>;>> > > > Date: Wed Mar 12 12:42:59 2014 +0900 > > > > > > elm_win: Unbreak the ABI break of window type. > > > > > > @fix > > > --- > > > src/lib/elm_win_common.h 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/lib/elm_win_common.h b/src/lib/elm_win_common.h > > > index b5eb567..3c88278 100644 > > > --- a/src/lib/elm_win_common.h > > > +++ b/src/lib/elm_win_common.h > > > @@ -9,7 +9,7 @@ > > > */ > > > typedef enum > > > { > > > - ELM_WIN_UNKNOWN, /**< Unknown window type. */ > > > + ELM_WIN_UNKNOWN = -1, /**< Unknown window type. */ > > > ELM_WIN_BASIC, /**< A normal window. Indicates a normal, top-level > > > window. Almost every window will be created with > this > > > type. */ > > > > > > -- > > > > > > > > > > > > > -- > > Gustavo Sverzut Barbieri > > -------------------------------------- > > Mobile: +55 (19) 99225-2202 > > Contact: http://www.gustavobarbieri.com.br/contact > > > ------------------------------------------------------------------------------ > > Learn Graph Databases - Download FREE O'Reilly Book > > "Graph Databases" is the definitive new guide to graph databases and > their > > applications. Written by three acclaimed leaders in the field, > > this first edition is now available. Download your free book today! > > http://p.sf.net/sfu/13534_NeoTech > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/13534_NeoTech > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/13534_NeoTech _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
