On Mon, Mar 24, 2014 at 12:55 PM, Carsten Haitzler <[email protected]>wrote:

> On Mon, 24 Mar 2014 11:07:38 +0900 Cedric BAIL <[email protected]> said:
>
> > On Sun, Mar 23, 2014 at 7:16 PM, Daniel Juyung Seo <[email protected]
> >
> > wrote:
> > > seoz pushed a commit to branch master.
> > >
> > >
> http://git.enlightenment.org/core/elementary.git/commit/?id=e64f8a1f09b4f222d2c15eec1220b6efb5ed7342
> > >
> > > commit e64f8a1f09b4f222d2c15eec1220b6efb5ed7342
> > > Author: Daniel Juyung Seo <[email protected]>
> > > Date:   Sun Mar 23 17:57:08 2014 +0900
> > >
> > >     macros: Fixed wrong ELM_RECTS_INCLUDE logic.
> >
> > Looks like it would be more robust to use Eina_Rectangle API to me.
>
> sure doesn't provide the same functionality though - to simply work on 2
> rects
> given the x/y/w/h params directly.
>
>
Yes I need eina_rectangle_include or something like that.
What could be a better name?

Daniel Juyung Seo (SeoZ)


> > > ---
> > >  src/lib/elm_macros.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/src/lib/elm_macros.h b/src/lib/elm_macros.h
> > > index 4656a89..c25e956 100644
> > > --- a/src/lib/elm_macros.h
> > > +++ b/src/lib/elm_macros.h
> > > @@ -6,4 +6,4 @@
> > >  #define ELM_RECTS_POINT_OUT(x, y, w, h, xx, yy) (((xx) < (x)) ||
> ((yy) <
> > >  #(y)) || ((xx) > ((x) + (w))) || ((yy) > ((y) + (h))))
> > >
> > >  // check if the rect (x, y, w, h) includes whole body of rect (xx,
> yy, ww,
> > > hh) -#define ELM_RECTS_INCLUDE(x, y, w, h, xx, yy, ww, hh) (((x) <=
> (xx))
> > > && (((x) + (w)) >= (xx)) && ((y) <= (yy)) && (((y) + (h)) >= (yy)))
> > > +#define ELM_RECTS_INCLUDE(x, y, w, h, xx, yy, ww, hh) (((x) <= (xx))
> &&
> > > (((x) + (w)) >= ((xx + (ww))) && ((y) <= (yy)) && (((y) + (h)) >=
> ((yy) +
> > > (hh)))))
> > >
> > > --
> > >
> > >
> > >
> >
> >
> >
> > --
> > Cedric BAIL
> >
> >
> ------------------------------------------------------------------------------
> > Learn Graph Databases - Download FREE O'Reilly Book
> > "Graph Databases" is the definitive new guide to graph databases and
> their
> > applications. Written by three acclaimed leaders in the field,
> > this first edition is now available. Download your free book today!
> > http://p.sf.net/sfu/13534_NeoTech
> > _______________________________________________
> > enlightenment-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
>
> --
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler)    [email protected]
>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to