stefan pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=5ce7f0e233a3db8b34af35655e15127e79dbda1f
commit 5ce7f0e233a3db8b34af35655e15127e79dbda1f Author: Stefan Schmidt <[email protected]> Date: Fri Mar 28 15:46:12 2014 +0100 label: Remove unused setting of foundflag before return. We are never going to check on foundflag here because we return right after setting it. Clear the code up a bit by not setting it at all. Found by Clang scan-build --- src/lib/elm_label.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/elm_label.c b/src/lib/elm_label.c index 3ad10ed..071ccaa 100644 --- a/src/lib/elm_label.c +++ b/src/lib/elm_label.c @@ -232,10 +232,8 @@ _get_value_in_key_string(const char *oldstring, const char *key, char **value) int key_len = strlen(key); endtag = curlocater + key_len; if ((!endtag) || (*endtag != '=')) - { - foundflag = 0; return -1; - } + firstindex = abs(oldstring - curlocater); firstindex += key_len + 1; // strlen("key") + strlen("=") *value = (char *)oldstring + firstindex; --
