raster pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=6dc6a96f803784eee2528fc42a07d4dc1a6aca88
commit 6dc6a96f803784eee2528fc42a07d4dc1a6aca88 Author: Vorobiov Vitalii <[email protected]> Date: Mon May 19 15:41:32 2014 +0900 [Fileselector] Fix double-call of callback function on clicking "Enter" key. Summary: This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file), so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard. This little feature was added in commit 4d761f3a63270c88fa516764d9288f8bf0ff4a11. Later the huge feature that adds key binding was implemented (commit 820f3dc907250c0c08ed8431b50567e58d6dab5c for ex). It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard). This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one. Because of that it was looks like "ok" button was clicked twice. This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing. @fix Reviewers: cedric, seoz, raster CC: reutskiy.v.v Differential Revision: https://phab.enlightenment.org/D864 --- src/lib/elc_fileselector.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/lib/elc_fileselector.c b/src/lib/elc_fileselector.c index 6e11998..686369d 100644 --- a/src/lib/elc_fileselector.c +++ b/src/lib/elc_fileselector.c @@ -1335,13 +1335,6 @@ _resource_deleted(void *data, int type EINA_UNUSED, void *ev) return ECORE_CALLBACK_PASS_ON; } -static void -_name_entry_activated_cb(void *data, Evas_Object *obj EINA_UNUSED, - void *event_info EINA_UNUSED) -{ - _ok(data, NULL, NULL); -} - EOLIAN static void _elm_fileselector_evas_smart_add(Eo *obj, Elm_Fileselector_Data *priv) { @@ -1430,8 +1423,6 @@ _elm_fileselector_evas_smart_add(Eo *obj, Elm_Fileselector_Data *priv) elm_entry_line_wrap_set(en, ELM_WRAP_CHAR); evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND); evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL); - evas_object_smart_callback_add(en, "activated", - _name_entry_activated_cb, obj); elm_widget_sub_object_add(obj, en); priv->name_entry = en; --
