On 05/21/2014 02:49 PM, Daniel Juyung Seo wrote: > it->on_deletion is heavily used in ELM_WIDGET_ITEM_RETURN_IF_ONDEL macro. > It looks quite dangerous to remove this because item deletion can be > deferred in some cases when del_pre_func returns false. > naviframe, flipselector, gengrid, genlist, list can return false. > > But the author of that code is bluezery(Taehwan Kim) so if eo can cover the > cases, you can remove it as bluezery mentioned. > However, please consider it once more before you just remove it. > > Thanks. > > Daniel Juyung Seo (SeoZ) > > > On Wed, May 21, 2014 at 3:53 PM, Bluezery <[email protected]> wrote: > >> 2014. 5. 13. 오후 6:56에 "Yossi Kantor" <[email protected]>님이 작성: >>> >>> With pleasure ! (Muahahah.) >>> >>> Thanks! >>> >>> On 05/13/2014 11:58 AM, ChunEon Park wrote: >>>> remove it! >>>> >>>> ------------------------------------ >>>> -Regards, Hermet- >>>> >>>> -----Original Message----- >>>> From: "Yossi Kantor"<[email protected]> >>>> To: "Enlightenment developer list"< >> [email protected]>; >>>> Cc: >>>> Sent: 2014-05-13 (화) 17:26:22 >>>> Subject: [E-devel] Elm_Widget_Item on_deletion property >>>> >>>> Hello, >>>> >>>> Elm_Widget_Item struct has a property boolean on_deletion. It is set to >>>> TRUE >>>> only once when item is deleted and freed. Its checked for not >>>> TRUE(OR_RETURN) on (almost) each >>>> modifying function. I looked around the code and found no other >>>> references for it. >>>> Since the item is freed right after setting this value in the same >>>> function, this property >>>> and it checks look redundant even for thread safety. >>>> So unless I am missing something I'd like to remove it (In a new eo >>>> interface). >> yes that is a workaround code. Eo can replace it. >> >>>> Tnx, >>>> Yossi. >>>> >>>> >> ------------------------------------------------------------------------------ >>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >>>> Instantly run your Selenium tests across 300+ browser/OS combos. >>>> Get unparalleled scalability from the best Selenium testing platform >> available >>>> Simple to use. Nothing to install. Get started now for free." >>>> http://p.sf.net/sfu/SauceLabs >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>> >>>> >> ------------------------------------------------------------------------------ >>>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >>>> Instantly run your Selenium tests across 300+ browser/OS combos. >>>> Get unparalleled scalability from the best Selenium testing platform >> available >>>> Simple to use. Nothing to install. Get started now for free." >>>> http://p.sf.net/sfu/SauceLabs >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> >>> >> ------------------------------------------------------------------------------ >>> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >>> Instantly run your Selenium tests across 300+ browser/OS combos. >>> Get unparalleled scalability from the best Selenium testing platform >> available >>> Simple to use. Nothing to install. Get started now for free." >>> http://p.sf.net/sfu/SauceLabs >>> _______________________________________________ >>> enlightenment-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> ------------------------------------------------------------------------------ >> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE >> Instantly run your Selenium tests across 300+ browser/OS combos. >> Get unparalleled scalability from the best Selenium testing platform >> available >> Simple to use. Nothing to install. Get started now for free." >> http://p.sf.net/sfu/SauceLabs >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE > Instantly run your Selenium tests across 300+ browser/OS combos. > Get unparalleled scalability from the best Selenium testing platform available > Simple to use. Nothing to install. Get started now for free." > http://p.sf.net/sfu/SauceLabs > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel Thank you very much, note taken. I'll see when I'll get to the files you mentioned.
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
