On 19/06/14 15:23, Stefan Schmidt wrote: > Hello. > > On Thu, 2014-06-19 at 14:51, Tom Hacohen wrote: >> Coverage doesn't work for me without it, and yes, I have tested it. > > Strange as it is broken for me on both my local system as well as on > jenkins with this change. > >> Also, I looked at it, and it looks correct. We have sources in both >> srcdir and builddir, and both paths were relative to srcdir, not >> srcdir/src here. > > What sources relevaant to coverage do we have in builddir which we > don't have in srcdir? > >> Honestly though, lcov is so broken it's not even funny. >> Try and look at the docs. You can't have more than 1 search path, and >> they support "auto search path" which doesn't really work. >> >> If you say it fixes it for jenkins, fine, do it. However, it's still >> broken here, with builddir == srcdir/build (i.e build/ inside the repo). > > It fixes it for me locally as well as on jenkins. No idea how your > setup differs. If we find a way to have it work for your setup as well > I'm fine with changing it but this commit broke the existing use.
My setup is now broken regardless, so I can't really check. My issue was with the generated .eo.[ch] files that are in builddir. They should be ignored, but they are first detected before they can be ignored, and everything falls apart because they can't be found. -- Tom. ------------------------------------------------------------------------------ HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing & Easy Data Exploration http://p.sf.net/sfu/hpccsystems _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
