On Tue, 8 Jul 2014 12:07:57 +0200 Cedric BAIL <cedric.b...@free.fr> said:
> NON ! This warning where there correctly as there is a real ABI break > here ! Please revert ! i know. but there is no other sensible way to support c++ as you need an extra data member and that struct was never designed for expansion. no versioning and its used as a static const in code. not without adding a "struct2" and eldbus isn't widely used (in fact that struct pretty much is not used outside of elementary, efl itself, enlightenment, terminology and enjoy). so what do you do? add a Eldbus_Service_Interface_Desc2 for the masses of basically zero users, or break abi? otherwise revert all the eldbus c++ code and go back to the drawingboard. > On Tue, Jul 8, 2014 at 5:44 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > > raster pushed a commit to branch master. > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=8ae3899e3e8a1df84be10845c05f0935c0a17e9b > > > > commit 8ae3899e3e8a1df84be10845c05f0935c0a17e9b > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > Date: Tue Jul 8 12:45:55 2014 +0900 > > > > fix eldbus based warnings > > --- > > src/lib/elm_app_server.c | 2 +- > > src/lib/elm_dbus_menu.c | 2 +- > > src/lib/elm_systray.c | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/lib/elm_app_server.c b/src/lib/elm_app_server.c > > index 4acc022..e6f2039 100644 > > --- a/src/lib/elm_app_server.c > > +++ b/src/lib/elm_app_server.c > > @@ -190,7 +190,7 @@ static const Eldbus_Property _props[] = { > > }; > > > > static const Eldbus_Service_Interface_Desc iface_desc = { > > - "org.enlightenment.Application1", _methods, NULL, _props, NULL, NULL > > + "org.enlightenment.Application1", _methods, NULL, _props, NULL, NULL, > > NULL }; > > > > EOLIAN static void > > diff --git a/src/lib/elm_dbus_menu.c b/src/lib/elm_dbus_menu.c > > index 021ee3b..72aaf7d 100644 > > --- a/src/lib/elm_dbus_menu.c > > +++ b/src/lib/elm_dbus_menu.c > > @@ -877,7 +877,7 @@ static const Eldbus_Property _properties[] = { > > }; > > > > static const Eldbus_Service_Interface_Desc _interface = { > > - DBUS_INTERFACE, _methods, _signals, _properties, NULL, NULL > > + DBUS_INTERFACE, _methods, _signals, _properties, NULL, NULL, NULL > > }; > > // > > ============================================================================= > > > > diff --git a/src/lib/elm_systray.c b/src/lib/elm_systray.c > > index 45ca469..dbf1a3f 100644 > > --- a/src/lib/elm_systray.c > > +++ b/src/lib/elm_systray.c > > @@ -290,7 +290,7 @@ static const Eldbus_Property properties[] = { > > }; > > > > static const Eldbus_Service_Interface_Desc _iface_desc = { > > - INTERFACE, methods, signals, properties, NULL, NULL > > + INTERFACE, methods, signals, properties, NULL, NULL, NULL > > }; > > // > > ============================================================================= > > > > > > -- > > > > > > > > > > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > Open source business process management suite built on Java and Eclipse > Turn processes into business applications with Bonita BPM Community Edition > Quickly connect people, data, and systems into organized workflows > Winner of BOSSIE, CODIE, OW2 and Gartner awards > http://p.sf.net/sfu/Bonitasoft > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
