Hello. On Fri, 2014-08-01 at 02:08, Stefan Schmidt wrote: > stefan pushed a commit to annotated tag v1.11.0-alpha1. > > http://git.enlightenment.org/core/elementary.git/commit/?id=f6c39d782cbf63541659bbb4f178fb1d6943e86e > > commit f6c39d782cbf63541659bbb4f178fb1d6943e86e > Author: Stefan Schmidt <s.schm...@samsung.com> > Date: Fri Aug 1 09:56:29 2014 +0200 > > build: Avoid -shared LDFLAG to allow me to have a working distcheck > > The -shared option in LDFLAG somehow is poisoning the configure run inside > distcheck. This results in the compiler test getting a segfault and > failing. > > I would really like to understand why this is needed to be set here > manually > anyway. Same for fPIC and dPIC. I would expect that we leave this to the > user > compiling the code or the packager. Skimming through the log only brought > up > fixing c++11 globally. Not really a commit message that helps me to > understand why this is needed... > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 6188c05..bd4bb25 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -246,7 +246,7 @@ if test "x${HAVE_CXX11}" = "x1" -a "x${want_cxx11}" = > "xyes"; then > evas-cxx >= efl_version \ > " > have_cxx11="yes" > - LDFLAGS="${LDFLAGS} -shared -fPIC -DPIC" > + LDFLAGS="${LDFLAGS} -fPIC -DPIC" > CXXFLAGS="${CXXFLAGS} -fPIC -DPIC"
Anyone can explain me why this needs to get hardcoded inside our build for c++11? This smells totally wrong to me and at least the -shared option actually caused my rouble. Interestingly not for others. What was the orignal intention to get this in? regards Stefan Schmidt ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
