Hello.

Still on my way through the API/ABI reports form 1.10 to 1.11

On Fri, 2014-06-13 at 01:18, Jean-Philippe ANDRXX wrote:
> jpeg pushed a commit to branch master.
> 
> http://git.enlightenment.org/core/efl.git/commit/?id=c21968bcd76e07ff300c8e102c0062f74fcb704d
> 
> commit c21968bcd76e07ff300c8e102c0062f74fcb704d
> Author: Jean-Philippe Andre <[email protected]>
> Date:   Fri Jun 13 16:56:39 2014 +0900
> 
>     Eet: Add support for ETC2 encoding and decoding
>     
>     Since we now have full support for ETC2, add the colorspaces
>     to Eet.
>     
>     @feature
> ---
>  src/Makefile_Eet.am     |   2 +
>  src/lib/eet/Eet.h       |   8 +-
>  src/lib/eet/eet_image.c | 310 
> +++++++++++++++++++++++++++++++++++-------------
>  3 files changed, 237 insertions(+), 83 deletions(-)
> 
>  lib_eet_libeet_la_CPPFLAGS = -I$(top_builddir)/src/lib/efl \
> diff --git a/src/lib/eet/Eet.h b/src/lib/eet/Eet.h
> index 50645a0..95be2e5 100644
> --- a/src/lib/eet/Eet.h
> +++ b/src/lib/eet/Eet.h
> @@ -477,14 +477,18 @@ typedef enum _Eet_Image_Encoding
>  {
>     EET_IMAGE_LOSSLESS = 0,
>     EET_IMAGE_JPEG = 1,
> -   EET_IMAGE_ETC1 = 2
> +   EET_IMAGE_ETC1 = 2,
> +   EET_IMAGE_ETC2_RGB = 3,
> +   EET_IMAGE_ETC2_RGBA = 4
>  } Eet_Image_Encoding;
>  
>  typedef enum _Eet_Colorspace
>  {
>     EET_COLORSPACE_ARGB8888 = 0,
>     /* The number between are reserved to preserve compatibility with evas */
> -   EET_COLORSPACE_ETC1 = 8
> +   EET_COLORSPACE_ETC1 = 9,

Reported by the ABI checker and it seems valid to me. We should keep
it at 8 here and leave 9 empty or move all newly added ones one up.

All all code that might comapre to this will be wrong now and we have
an ABI break. Agreed?

> +   EET_COLORSPACE_RGB8_ETC2 = 10,
> +   EET_COLORSPACE_RGBA8_ETC2_EAC = 11
>  } Eet_Colorspace;

regards
Stefan Schmidt

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to