Hello.

On Thu, 2014-08-07 at 15:25, Tom Hacohen wrote:
> On 07/08/14 15:13, Stefan Schmidt wrote:
> > Hello.
> >
> > Looking through newly added API for 1.11 right now.
> >
> > On Tue, 2014-06-10 at 00:18, Lukasz Stanislawski wrote:
> >> raster pushed a commit to branch master.
> >>
> >> http://git.enlightenment.org/core/elementary.git/commit/?id=0c5c00ee68bb0c4cf7f4ecea7912ff14025129c8
> >>
> >> commit 0c5c00ee68bb0c4cf7f4ecea7912ff14025129c8
> >> Author: Lukasz Stanislawski <lukasz.stanislaw...@gmail.com>
> >> Date:   Tue Jun 10 16:18:17 2014 +0900
> >>
> >>      atspi: add AtspiText and AtspiEditableText interface support.
> >>
> >>      Summary:
> >>      Added reference interface implementation for elm_entry widget. Tests 
> >> added.
> >>      Updated at-spi-constants.h header to version 2.12.0.
> >>
> >>      Reviewers: raster, seoz
> >>
> >>      CC: raster
> >>
> >>      Differential Revision: https://phab.enlightenment.org/D806
> >> ---
> >
> > [SNIP]
> >
> >> +
> >> +/**
> >> + * @brief Free Elm_Atspi_Text_Attribute structure
> >> + */
> >> +void elm_atspi_text_text_attribute_free(Elm_Atspi_Text_Attribute *attr);
> >
> > This one show up as a newly added symbol. It has no EAPI defined
> > though. Should this be an internal or public symbol?
> >
> > If public we whould use EAPI here plus a bit more doxygen description
> > and @since 1.11. If on the other hand this should be internal only we
> > need to have a look why it shows up externally.
> 
> I have -fvisibility=hidden in my cflags, so it doesn't look like 
> something is wrong with my .so generation. Maybe it was just detected by 
> the tool's header scanner?

Hmm, good question. I was thinking the tools verify the symbol from
the .so as well.

It does not do this for other internal symbols, right? Something to
look into. Maybe tomorrow.

regards
Stefan Schmidt

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to