raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=fa5b0529115be47c2ab4a1abebc37c5118fdcff6

commit fa5b0529115be47c2ab4a1abebc37c5118fdcff6
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date:   Wed Aug 13 20:21:14 2014 +0900

    fix coveirty range complaint on modifer bit mask
    
    this fixes CID 1224356, 1224355, 1224354, 1224353 and 1224352
---
 src/lib/evas/canvas/evas_key.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/lib/evas/canvas/evas_key.c b/src/lib/evas/canvas/evas_key.c
index d8e6d67..68c455d 100644
--- a/src/lib/evas/canvas/evas_key.c
+++ b/src/lib/evas/canvas/evas_key.c
@@ -151,8 +151,7 @@ _evas_canvas_key_modifier_on(Eo *eo_e EINA_UNUSED, 
Evas_Public_Data *e, const ch
 
    n = (Evas_Modifier_Mask)evas_key_modifier_number(&(e->modifiers), keyname);
    if (n < 0 || n > 63) return;
-   num = (Evas_Modifier_Mask)n;
-   num = 1 << num;
+   num = 1 << n;
    e->modifiers.mask |= num;
 }
 
@@ -164,8 +163,7 @@ _evas_canvas_key_modifier_off(Eo *eo_e EINA_UNUSED, 
Evas_Public_Data *e, const c
 
    n = evas_key_modifier_number(&(e->modifiers), keyname);
    if (n < 0 || n > 63) return;
-   num = (Evas_Modifier_Mask)n;
-   num = 1 << num;
+   num = 1 << n;
    e->modifiers.mask &= ~num;
 }
 
@@ -177,8 +175,7 @@ _evas_canvas_key_lock_on(Eo *eo_e EINA_UNUSED, 
Evas_Public_Data *e, const char *
 
    n = evas_key_lock_number(&(e->locks), keyname);
    if (n < 0 || n > 63) return;
-   num = (Evas_Modifier_Mask)n;
-   num = 1 << num;
+   num = 1 << n;
    e->locks.mask |= num;
 }
 
@@ -190,8 +187,7 @@ _evas_canvas_key_lock_off(Eo *eo_e EINA_UNUSED, 
Evas_Public_Data *e, const char
 
    n = evas_key_lock_number(&(e->locks), keyname);
    if (n < 0 || n > 63) return;
-   num = (Evas_Modifier_Mask)n;
-   num = 1 << num;
+   num = 1 << n;
    e->locks.mask &= ~num;
 }
 

-- 


Reply via email to