On 04/09/14 13:06, Stefan Schmidt wrote:
> Hallo.
>
> On 04/09/14 13:59, Tom Hacohen wrote:
>> On 04/09/14 12:44, Stefan Schmidt wrote:
>>> Hello.
>>>
>>> On 04/09/14 13:19, Tom Hacohen wrote:
>>>> Are you sure about this one? It doesn't look correct.
>>> I thought so. Would not have pushed if I was not sure. But lets go
>>> through this.
>>>> Someone was setting ok to false inside the {} and then checking for it's
>>> The ok insoide {} was there before. Raster added the earlier ok in the
>>> latest commit.
>>>> value. You changed it to set ok after the if.
>>> ok is false at function start. Thus it is also false during the {} block
>>> here. Means this block can have its magic and return or not.
>>>
>>> Afterwards I reset it to false because that is what the latest patch
>>> expected it to be initially.
>>>
>>> I agree that it looks strange that we retrun if ok is false and
>>> afterwards reset the same var to false but this comes from the fact that
>>> we use the same var for two cases here. At least that is how I
>>> understand the code.
>>>
>>> If we leave ok as true we would have a problem at line 466 where ok
>>> would all of a sudden be true while the checks above would never set it so.
>>>
>>
>> I trust you if you are sure. I haven't read the code, just the diff, and
>> it looks weird. If you took a look and made sure, I'm sure it's fine.
>> Just wanted to point the oddity out.
>
> Agreed, looks a bit strange. I'm sure as far as I understand the code.
> Will check with raster though ones I see him again so he can point out
> if it is meant differently.
> Always good to have below review incoming code. :)Raster just committed the exact same patch to efl 1.11, so good. :) > > regards > Stefan Schmidt > >>> regards >>> Stefan Schmidt >>>> On 04/09/14 12:18, Stefan Schmidt wrote: >>>>> stefan pushed a commit to branch master. >>>>> >>>>> http://git.enlightenment.org/core/efl.git/commit/?id=edcee427fd22a1639f49ce12a505c6e471d89e08 >>>>> >>>>> commit edcee427fd22a1639f49ce12a505c6e471d89e08 >>>>> Author: Stefan Schmidt <s.schm...@samsung.com> >>>>> Date: Thu Sep 4 13:16:30 2014 +0200 >>>>> >>>>> ecore_x_vsync: Remove ahadowign variable. >>>>> >>>>> Also make sure we reset ok to FALSE here to keep the logic below >>>>> correct. >>>>> This was actually a vlaid local shadow problem. >>>>> --- >>>>> src/lib/ecore_x/xlib/ecore_x_vsync.c | 3 +-- >>>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>>> >>>>> diff --git a/src/lib/ecore_x/xlib/ecore_x_vsync.c >>>>> b/src/lib/ecore_x/xlib/ecore_x_vsync.c >>>>> index fbf011d..59a9231 100644 >>>>> --- a/src/lib/ecore_x/xlib/ecore_x_vsync.c >>>>> +++ b/src/lib/ecore_x/xlib/ecore_x_vsync.c >>>>> @@ -396,8 +396,6 @@ _drm_init(void) >>>>> // only do this on new kernels = let's say 3.14 and up. 3.16 >>>>> definitely >>>>> // works >>>>> { >>>>> - Eina_Bool ok = EINA_FALSE; >>>>> - >>>>> FILE *fp = fopen("/proc/sys/kernel/osrelease", "r"); >>>>> if (fp) >>>>> { >>>>> @@ -414,6 +412,7 @@ _drm_init(void) >>>>> } >>>>> if (!ok) return 0; >>>>> } >>>>> + ok = EINA_FALSE; >>>>> >>>>> snprintf(buf, sizeof(buf), "/dev/dri/card1"); >>>>> if (stat(buf, &st) == 0) >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Slashdot TV. >>>> Video for Nerds. Stuff that matters. >>>> http://tv.slashdot.org/ >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> enlightenment-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >>> ------------------------------------------------------------------------------ >>> Slashdot TV. >>> Video for Nerds. Stuff that matters. >>> http://tv.slashdot.org/ >>> _______________________________________________ >>> enlightenment-devel mailing list >>> enlightenment-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> >> >> >> ------------------------------------------------------------------------------ >> Slashdot TV. >> Video for Nerds. Stuff that matters. >> http://tv.slashdot.org/ >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
