On Wed, 10 Sep 2014 14:42:44 +0100 Tom Hacohen <tom.haco...@samsung.com> said:
> I didn't make much noise when you broke theme API for e19 (for no real > reason) because I didn't feel like arguing. But back-porting a breaking > change is too much. You essentially screwed over anyone who's tracking > stable e18 and efl-1.11.0 (or lower). They'll update only to find out > their pager is completely broken, although it's meant to be stable. Same > goes with custom made themes. > An example of a distro you just broke: Arch. > You should have probably just added a configure dependency to e18 saying > it only works with efl < 1.11.2 (retarded, but better than what you did). > > You shouldn't have changed that in e19, you definitely shouldn't have > backported it, and you definitely shouldn't have released an e18 > "stable" (but broken) version just like that. > > This again proves how annoying moving the e theme to elm is, but even if > the e theme was in tree, this is just a stupid theme-api breaking change. i reverted them already on the basis that this is a break as you say - people on e18 can't upgrade to efl 1.11.2 or 1.12. that alone is reason enough. we need to move forward without breaking. if that mans duplicating, so be it. if it means its a bit ugly - so be it, but we should avoid breaks -if we consciously know they are going to happen. that includes theme. > -- > Tom. > > On 10/09/14 14:29, Mike Blumenkrantz wrote: > > discomfitor pushed a commit to branch enlightenment-0.18. > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=4bca1ed0efcf489b684399c72c8b6a984d61f936 > > > > commit 4bca1ed0efcf489b684399c72c8b6a984d61f936 > > Author: Mike Blumenkrantz <zm...@osg.samsung.com> > > Date: Wed Sep 10 09:26:56 2014 -0400 > > > > rename pager theme stuff to pager_plain to match current elm > > --- > > src/modules/pager/e_mod_main.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/src/modules/pager/e_mod_main.c b/src/modules/pager/e_mod_main.c > > index f69b11e..719ab46 100644 > > --- a/src/modules/pager/e_mod_main.c > > +++ b/src/modules/pager/e_mod_main.c > > @@ -432,7 +432,7 @@ _pager_desk_new(Pager *p, E_Desk *desk, int xpos, int > > ypos, Eina_Bool invert) o = edje_object_add(e); > > pd->o_desk = o; > > e_theme_edje_object_set(o, "base/theme/modules/pager", > > - "e/modules/pager/desk"); > > + "e/modules/pager_plain/desk"); > > edje_object_part_text_set(o, "e.text.label", desk->name); > > if (pager_config->show_desk_names) > > edje_object_signal_emit(o, "e,name,show", "e"); > > @@ -664,7 +664,7 @@ _pager_window_new(Pager_Desk *pd, E_Border *border) > > o = edje_object_add(evas_object_evas_get(pd->pager->o_table)); > > pw->o_window = o; > > e_theme_edje_object_set(o, "base/theme/modules/pager", > > - "e/modules/pager/window"); > > + "e/modules/pager_plain/window"); > > if (visible) evas_object_show(o); > > > > e_layout_pack(pd->o_layout, pw->o_window); > > @@ -795,7 +795,7 @@ _pager_popup_new(E_Zone *zone, int keyaction) > > > > pp->o_bg = edje_object_add(pp->popup->evas); > > e_theme_edje_object_set(pp->o_bg, "base/theme/modules/pager", > > - "e/modules/pager/popup"); > > + "e/modules/pager_plain/popup"); > > desk = e_desk_current_get(zone); > > if (desk) > > edje_object_part_text_set(pp->o_bg, "e.text.label", desk->name); > > @@ -1930,7 +1930,7 @@ _pager_window_cb_mouse_move(void *data, Evas *e > > __UNUSED__, Evas_Object *obj __U > > > > o = edje_object_add(drag->evas); > > e_theme_edje_object_set(o, "base/theme/modules/pager", > > - "e/modules/pager/window"); > > + "e/modules/pager_plain/window"); > > evas_object_show(o); > > > > oo = e_border_icon_add(pw->border, drag->evas); > > @@ -2311,7 +2311,7 @@ _pager_desk_cb_mouse_move(void *data, Evas *e > > __UNUSED__, Evas_Object *obj __UNU /* redraw the desktop theme above */ > > o = edje_object_add(drag->evas); > > e_theme_edje_object_set(o, "base/theme/modules/pager", > > - "e/modules/pager/desk"); > > + "e/modules/pager_plain/desk"); > > evas_object_show(o); > > e_drag_object_set(drag, o); > > > > @@ -2332,7 +2332,7 @@ _pager_desk_cb_mouse_move(void *data, Evas *e > > __UNUSED__, Evas_Object *obj __UNU > > > > o = edje_object_add(drag->evas); > > e_theme_edje_object_set(o, "base/theme/modules/pager", > > - "e/modules/pager/window"); > > + "e/modules/pager_plain/window"); > > e_layout_pack(oo, o); > > e_layout_child_raise(o); > > e_zone_useful_geometry_get(pw->desk->desk->zone, > > > > > > ------------------------------------------------------------------------------ > Want excitement? > Manually upgrade your production database. > When you want reliability, choose Perforce > Perforce version control. Predictably reliable. > http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
