On 27/10/14 09:23, Vyacheslav Reutskiy wrote: > rimmed pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=4d7c0fe3d941d0b19e1a7aa881979fafcbc83aba > > commit 4d7c0fe3d941d0b19e1a7aa881979fafcbc83aba > Author: Vyacheslav Reutskiy <rim...@yandex.ru> > Date: Mon Oct 27 09:21:45 2014 +0000 > > edje: edje_edit - don't unlick(NULL) > > Summery: fix, posible to delete file by 'NULL' path (T1760) > > @fix > --- > src/lib/edje/edje_edit.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/lib/edje/edje_edit.c b/src/lib/edje/edje_edit.c > index 2693506..491e202 100644 > --- a/src/lib/edje/edje_edit.c > +++ b/src/lib/edje/edje_edit.c > @@ -9466,8 +9466,11 @@ _edje_edit_embryo_rebuild(Edje_Edit *eed) > the_way_out: > fclose(f); > the_doorway: > - unlink(tmp_out); > - eina_tmpstr_del(tmp_out); > + if (tmp_out) > + { > + unlink(tmp_out); > + eina_tmpstr_del(tmp_out); > + } > almost_out: > unlink(tmp_in); > eina_tmpstr_del(tmp_in); >
Hey, A few comments: 1. Please backport the fix. 2. You have a typo in summary line, watch out for those. 3. Please next time put "Fixes T1760" in a separate line so phab automatically detects it and closes the ticket for you. -- Tom. ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
