Hi Stefan
Sorry man this was my mistake. It was most silly one and I will make sure
this never happens in future.
Thanks for pointing that out.
cheers
Kabeer
------- Original Message -------
Sender : Stefan Schmidt<ste...@datenfreihafen.org>
Date : Jan 16, 2015 14:04 (GMT+05:30)
Title : Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: wl_drm: Fix
creation of the ecore_evas_gl_drm
Hello.
On 15/01/15 19:30, Christopher Michael wrote:
> devilhorns pushed a commit to branch master.
>
>
http://git.enlightenment.org/core/enlightenment.git/commit/?id=63dc694f56e8e
ae061cc7bbfde4b91e6fa48bd29
>
> commit 63dc694f56e8eae061cc7bbfde4b91e6fa48bd29
> Author: Chris Michael
> Date: Thu Jan 15 13:29:43 2015 -0500
>
> wl_drm: Fix creation of the ecore_evas_gl_drm
>
> Signed-off-by: Chris Michael
> ---
> src/modules/wl_drm/e_mod_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/modules/wl_drm/e_mod_main.c
b/src/modules/wl_drm/e_mod_main.c
> index 118f9ef..795c415 100644
> --- a/src/modules/wl_drm/e_mod_main.c
> +++ b/src/modules/wl_drm/e_mod_main.c
> @@ -76,8 +76,8 @@ e_modapi_init(E_Module *m)
> if ((e_comp_gl_get()) &&
> (e_comp_config_get()->engine == E_COMP_ENGINE_GL))
> {
> - comp->ee == ecore_evas_gl_drm_new(NULL, 0, 0, 0, 1, 1);
> - if(!comp->ee)
> + comp->ee = ecore_evas_gl_drm_new(NULL, 0, 0, 0, 1, 1);
> + if (!comp->ee)
> e_comp_gl_set(EINA_FALSE);
> }
>
If we get a patch in phab which has only two lines of changes and both
of them have to be fixed afterwards I would suggest that we don't submit
this one as is and do a fix commit afterwards.
The idea to review patches from people is that we provide feedback
before the code enters our repo and the contributor can learn and
hopefully improve his patches.
regards
Stefan Schmidt
----------------------------------------------------------------------------
--
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[cid:BGFC2LL5XOK0@namo.co.kr]
[SeenTimeChecker?do=6db27cebcd8822fb24b6d4333447f6560d5fc3afaf7efa5d53e47e2f
243a5ca9ddc79e3cd10304db25139e580ce36374e458eb91567068af8048f33cf1ed6b022630
67d8b8f027b11b20909a04efd4d2748cfe1d4e847419cf878f9a26ce15a0]
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
