herdsman pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7cbf22212f0c3292dbd1919f4cdd15802e9b9d84
commit 7cbf22212f0c3292dbd1919f4cdd15802e9b9d84
Author: Daniel Hirt <daniel.h...@samsung.com>
Date: Mon Feb 2 14:10:04 2015 +0200
Revert "eina: eina_file - fix "invalid read of size 1" in valgrind"
This reverts commit f52f5628916f44a6b8ce1fdd3b9cc40f6c997eda.
This is reverted because it breaks eina_file_path_sanitize when using
"/../" in paths, for example:
eina_file_path_sanitize("/home/../mydir/myfile")
returns: "/mydir/myfili"
What invalid read size does this fix? Why was no test case specified?
Anyway, this change affects too much code to leave it in like this.
---
src/lib/eina/eina_file_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/eina/eina_file_common.c b/src/lib/eina/eina_file_common.c
index 6a573da..3e5b615 100644
--- a/src/lib/eina/eina_file_common.c
+++ b/src/lib/eina/eina_file_common.c
@@ -88,7 +88,7 @@ _eina_file_escape(char *path, size_t len)
char tmp;
len -= p + 3 - q;
- memmove(q, p + 3, len - (q - result) - 1);
+ memmove(q, p + 3, len - (q - result));
result[len] = '\0';
p = q;
--
