seoz pushed a commit to branch master.
http://git.enlightenment.org/core/elementary.git/commit/?id=84f28cc3871269440d53a26e64a43823041e9560
commit 84f28cc3871269440d53a26e64a43823041e9560
Author: VBS <vdtizen....@samsung.com>
Date: Wed Feb 4 08:30:06 2015 +0900
Gengrid : Fix memory leak in elm_gengrid_realized_items_update
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory
share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
---
src/lib/elm_gengrid.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
index f6506f5..3396211 100644
--- a/src/lib/elm_gengrid.c
+++ b/src/lib/elm_gengrid.c
@@ -4109,11 +4109,11 @@ _elm_gengrid_realized_items_get(Eo *obj EINA_UNUSED,
Elm_Gengrid_Data *sd)
EOLIAN static void
_elm_gengrid_realized_items_update(Eo *obj, Elm_Gengrid_Data *_pd EINA_UNUSED)
{
- Eina_List *list, *l;
+ Eina_List *list;
Elm_Object_Item *it;
list = elm_gengrid_realized_items_get(obj);
- EINA_LIST_FOREACH(list, l, it)
+ EINA_LIST_FREE(list, it)
elm_gengrid_item_update(it);
}
--
