On Wed, Feb 4, 2015 at 4:37 PM, Christopher Michael <devilho...@comcast.net>
wrote:

> devilhorns pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/efl.git/commit/?id=cf9f64cfc6f5c7a14d315553dacd94c653a04f3d
>
> commit cf9f64cfc6f5c7a14d315553dacd94c653a04f3d
> Author: Chris Michael <cp.mich...@samsung.com>
> Date:   Wed Feb 4 11:23:24 2015 -0500
>
>     ecore-x: Deprecate misspelled screensaver API function
>
>     Summary: This API function is misspelled, so after speaking with
>     Stefan, we've decided to deprecate this function add add a properly
>     spelled one.
>

Sorry to pull a TAsn here, but dude, wtf? you could've merged cf9f64c,
5256425 and 5030782 together (one changes function prototype only, the
other changes implementation in one place and the third changes *the same
implementation* in another place!). This is ridiculous. For how long is
this one-line-per-commit crap gonna continue?


>
>     @fix
>
>     Signed-off-by: Chris Michael <cp.mich...@samsung.com>
> ---
>  src/lib/ecore_x/Ecore_X.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/ecore_x/Ecore_X.h b/src/lib/ecore_x/Ecore_X.h
> index efdd2ff..b72957d 100644
> --- a/src/lib/ecore_x/Ecore_X.h
> +++ b/src/lib/ecore_x/Ecore_X.h
> @@ -1986,10 +1986,11 @@ EAPI int
>  ecore_x_screensaver_interval_get(void);
>  EAPI void
> ecore_x_screensaver_event_listen_set(Eina_Bool on);
>  EAPI Eina_Bool
>  ecore_x_screensaver_custom_blanking_enable(void); /** @since 1.7 */
>  EAPI Eina_Bool
>  ecore_x_screensaver_custom_blanking_disable(void); /** @since 1.7 */
> -EAPI void                            ecore_x_screensaver_supend(void);
> /** @since 1.11 */
> +EINA_DEPRECATED EAPI void            ecore_x_screensaver_supend(void);
> /** @since 1.11 */
>  EAPI void                            ecore_x_screensaver_resume(void);
> /** @since 1.11 */
>  EAPI void                            ecore_x_screensaver_reset(void); /**
> @since 1.11 */
>  EAPI void                            ecore_x_screensaver_activate(void);
> /** @since 1.11 */
> +EAPI void                            ecore_x_screensaver_suspend(void);
> /** @since 1.13 */
>
>  /* FIXME: these funcs need categorising */
>
>
> --
>
>
>
D5
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to