On Tue, Feb 03, 2015, Stefan Schmidt wrote: > Hello. > > On 01/02/15 19:02, Sebastian Dransfeld wrote: > > $(EXEEXT)? > > Fair point as this would avoid the ifdef alltogether. Is normally only > used in Makefile, right? Is is really available at this stage?
I'd say it probably isn't. Now, would it be worth adding it? Dunno. I think it's not used elsewhere. A way to reduce the duplication would probably be something like adding a trailing "%s" in the format and #ifdef _WIN32 , ".exe" #else , "" #endif in the arguments. With compiler optimizations the output code will probably be equivalent. (and it's not like it'd be dwarfed by the folllowing process spawning anyway). -- Adrien Nader > > ---- michelle legrand skrev ---- > > > >> cedric pushed a commit to branch master. > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=9431cde70e25ba40e7408ca11016e58977d09b2b > >> > >> commit 9431cde70e25ba40e7408ca11016e58977d09b2b > >> Author: michelle legrand <michelle.legr...@openwide.fr> > >> Date: Fri Jan 30 10:49:53 2015 +0100 > >> > >> eolian: fix to pass make check on windows > >> > >> @fix > >> > >> Signed-off-by: Cedric BAIL <ced...@osg.samsung.com> > >> --- > >> src/tests/eolian/eolian_generation.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/src/tests/eolian/eolian_generation.c > >> b/src/tests/eolian/eolian_generation.c > >> index 25fcddf..f3ccc71 100644 > >> --- a/src/tests/eolian/eolian_generation.c > >> +++ b/src/tests/eolian/eolian_generation.c > >> @@ -72,9 +72,15 @@ _eolian_gen_execute(const char *eo_filename, const char > >> *options, const char *ou > >> > >> if (getenv("EFL_RUN_IN_TREE")) > >> { > >> +#ifdef _WIN32 > >> + snprintf(eolian_gen_path, sizeof(eolian_gen_path), > >> + "%s/src/bin/eolian/eolian_gen.exe", > >> + PACKAGE_BUILD_DIR); > >> +#else > >> snprintf(eolian_gen_path, sizeof(eolian_gen_path), > >> "%s/src/bin/eolian/eolian_gen", > >> PACKAGE_BUILD_DIR); > >> +#endif > >> } > >> if (eolian_gen_path[0] == '\0') > >> return -1; > >> > >> -- > >> > >> > > ------------------------------------------------------------------------------ > > Dive into the World of Parallel Programming. The Go Parallel Website, > > sponsored by Intel and developed in partnership with Slashdot Media, is your > > hub for all things parallel software development, from weekly thought > > leadership blogs to news, videos, case studies, tutorials and more. Take a > > look and join the conversation now. http://goparallel.sourceforge.net/ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming. The Go Parallel Website, > sponsored by Intel and developed in partnership with Slashdot Media, is your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. Take a > look and join the conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
