On 05/02/15 23:22, Carsten Haitzler (The Rasterman) wrote: > On Thu, 05 Feb 2015 11:59:38 +0000 Tom Hacohen <tom.haco...@samsung.com> said: > >> On 04/02/15 23:48, Carsten Haitzler (The Rasterman) wrote: >>> On Wed, 04 Feb 2015 12:11:28 +0000 Tom Hacohen <tom.haco...@samsung.com> >>> said: >>> >>>> Hey, >>>> >>>> If there are no objections, I'd like to deprecate eina_tmpstr_strlen() >>>> and create eina_tmpstr_len() that is unlike the former, not crazily >>>> confusing and error prone. >>>> >>>> With a name like *_strlen() you'd expect a function would behave like >>>> strlen(), alas, it behaves like "strlen() + 1". This is mind bogglingly >>>> inconsistent and super confusing. There's already at least one bug >>>> associated with this craziness (https://phab.enlightenment.org/D1929), >>>> but I'm sure there are more to come/be discovered. >>>> >>>> I suggest we deprecate it and add tmpstr_len() that behaves like >>>> strlen() and all of the other string len functions of the efl. >>>> >>>> Any objections/comments? >>> >>> i'm with you on the length. it should be strlen length - no \0 included. >>> this is convention basically anywhere that deals with strings. >> >> Yes. >> >> Should I mark it as deprecated for this release and add the new API for >> the next one? Or just do both for the next one? > > i say wait until after release personally. marking as deprecated then lead to > maybe a bunch of warnings (with no solution unless you add a new func). we'd > maybe have to fix a bunch of code too to get rid of the warnings. >
Figured. Will do that after the release. What do you think, _length() to match add_length(), or _len() to match the rest of the world/eina? -- Tom. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
