Hi thanks for the patch.
1. Please put @fix in your commit message in this kind of commit as this is
an apparent bug and needs to be backported.
https://phab.enlightenment.org/w/git_practices/#commit-message
Depending on the nature of your commit some of the following tags might
apply:
@fix - You fixed a bug that does also apply for a released version (not
only code from this development cycle). We use this tag also as a marker
for backports.
@feature - This is one of the first commits introducing a new feature.
You don't have to repeat this tag for all commits concerning this feature.
Make sure your summary line is in really good shape and descriptive as this
will be used in the NEWS file for the release.
CID: XXXXX - This is used if you fixed a issue discovered by Coverity
scan. It gives credit to them and helps us to see which commit relates to
which issue.
TXXX - If you fix a bug or implemented a feature with a phab ticket
number please also add it.
2. Please fix genlist as well. They should be aligned together.
Thanks.
Daniel Juyung Seo (SeoZ)
On Tue, Feb 10, 2015 at 8:31 PM, Jaeun Choi <jaeun12.c...@samsung.com>
wrote:
> eunue pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/elementary.git/commit/?id=0debdcf1ca166da1c083765bdb1542183fe96427
>
> commit 0debdcf1ca166da1c083765bdb1542183fe96427
> Author: Jaeun Choi <jaeun12.c...@samsung.com>
> Date: Tue Feb 10 20:29:47 2015 +0900
>
> gengrid: call "selected" callback on entey key input
> ---
> src/lib/elm_gengrid.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/lib/elm_gengrid.c b/src/lib/elm_gengrid.c
> index 3396211..022e104 100644
> --- a/src/lib/elm_gengrid.c
> +++ b/src/lib/elm_gengrid.c
> @@ -2970,6 +2970,7 @@ _key_action_select(Evas_Object *obj, const char
> *params EINA_UNUSED)
> {
> eo_it = elm_object_focused_item_get(obj);
> ELM_GENGRID_ITEM_DATA_GET(eo_it, it);
> + evas_object_smart_callback_call(WIDGET(it), SIG_SELECTED, eo_it);
> evas_object_smart_callback_call(WIDGET(it), SIG_ACTIVATED, eo_it);
> return EINA_TRUE;
> }
>
> --
>
>
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
