On Thu, Feb 12, 2015 at 11:02 PM, Stefan Schmidt <ste...@datenfreihafen.org> wrote:
> Hello. > > On 12/02/15 14:51, Tom Hacohen wrote: > > On 12/02/15 09:25, Stefan Schmidt wrote: > >> stefan pushed a commit to branch master. > >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=8c7c48a3f745194d21f01b857c3640d6a9bb88d3 > >> > >> commit 8c7c48a3f745194d21f01b857c3640d6a9bb88d3 > >> Author: Stefan Schmidt <s.schm...@samsung.com> > >> Date: Thu Feb 12 10:23:50 2015 +0100 > >> > >> tests/evas: Disable segfaulting evas_object_mesh_loader_saver > >> > >> This test case segfault on jenkins as well as on my devel machine. > >> Disable until fixed. > >> > >> ref T2104 > >> --- > >> src/tests/evas/evas_test_mesh.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/src/tests/evas/evas_test_mesh.c > b/src/tests/evas/evas_test_mesh.c > >> index 558dcfa..a942014 100644 > >> --- a/src/tests/evas/evas_test_mesh.c > >> +++ b/src/tests/evas/evas_test_mesh.c > >> @@ -132,5 +132,5 @@ END_TEST > >> > >> void evas_test_mesh(TCase *tc) > >> { > >> - tcase_add_test(tc, evas_object_mesh_loader_saver); > >> + //tcase_add_test(tc, evas_object_mesh_loader_saver); > >> } > >> > > I know you already reverted this commit, but please avoid doing this in > > the future. The whole point of tests is to know if they're failing. A > > failing test is a good thing (that we need to fix), not hide and forget > > by disabling it... > > If the world would be so easily black and white. :) > > I normally don't disable them because I also think this is the correct way. > > But for example this case was more complicated as there was another test > suite > bug lingering behind this which I was only able to reproduce on jenkins > and not locally. > > So I needed a way of having one problem out of the way first to be able > to see the > other one. > > And yes, I also thought about the problem of forgetting thus I added a > ticket about it on > phab which I used to coordinate with Bogdan and kept track of it until I > finally could enable it again. > > Given that some problems with unit tests take a while to get resolved > letting them sit there > would render our whole CI infrastructure void. Which in turn means more > bugs are sneaking > in which will all reveal once the first one is fixed and jenkins works > again. I'm seeing this all the time. > > regards > Stefan Schmidt > > Well it would be nice if Jenkins sent mails with a "warning" in case of test failure rather than "build failed". I know make check also suffers from a similar problem where it's either pass or fail but I never see any warnings or skips. Cheers, -- Jean-Philippe André ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
