On Mon, Feb 23, 2015 at 4:23 PM, Tom Hacohen <tom.haco...@samsung.com> wrote: > On 23/02/15 15:16, Daniel Kolesa wrote: >> On Wed, Feb 18, 2015 at 9:43 PM, perepelits.m <perepelit...@samsung.com> >> wrote: >> >>> cedric pushed a commit to branch master. >>> >>> >>> http://git.enlightenment.org/core/efl.git/commit/?id=2e2145b5945c94587e5a11502432ea2e8f75d2bd >>> >>> commit 2e2145b5945c94587e5a11502432ea2e8f75d2bd >>> Author: perepelits.m <perepelit...@samsung.com> >>> Date: Wed Feb 18 22:00:58 2015 +0100 >>> >>> evas: Evas_3D - improve Shooter example. >>> >>> Summary: This example includes some previous developments to create >>> 3d-world mechanics. >>> >>> Reviewers: cedric, raster, Hermet >>> >>> Subscribers: cedric, artem.popov >>> >>> Differential Revision: https://phab.enlightenment.org/D1991 >>> >> >> Dude, what the hell? One does *NOT* simply commit 50MB of worthless (and >> mostly binary) assets into a Git repository (the space in the directory >> name is the least bad thing about this), *ESPECIALLY* our primary EFL >> repository; this is really bad (especially as the example looks like shit). >> I would say this deserves a revert, but sadly, it's forever written in our >> history and now *everyone* will be pulling the extra fucking 50MB... i hope >> you're happy. >> >> Do *NOT* do this kind of shit again. > > Yeah, Cedric, this is crazy! We've talked about it before with relation > to exactness! Pushing this amount of crazy useless data just for the > sake of better examples is crazy and stupid. As Daniel said, the space > in the directory name and the use of capital letters, while major > offences on their own, are nothing in comparison to this shit. Have you > even reviewed this crazy patch before pushing it?! > > It's still worth reverting this, as at least people doing shallow clones > won't have to suffer this craziness. Cedric, please revert this and > never do this shit again. :( Make a 3d examples repo if you are so keen > to have one. **Please revert this** > > Just to repeat this again: while nothing in comparison to the massive > binary dump, the space in the filename and the use of caps is enough to > reject this. What's the point of even reviewing patches if you don't > stop obvious craziness at the door?
I only reviewed the code. I didn't see nor noticed the size of the asset. As an example, it is a quite complete example of what you can do with Evas_3D and how to use it. As for the asset, they should indeed be reduced and renamed. -- Cedric BAIL ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
