On 04/03/15 16:56, Christopher Michael wrote: > Commit guidelines. > > Yakov, when you push commits, make sure they conform to our commit > guidelines. In this case, the summary line. This is not a single > instance, I've seen others too.
See my other email, this is not covered by the efl commit guidelines, and anyhow, even if it was, there's nothing specifically wrong with it. Yeah, it's not the best commit message, but it does conform with the guidelines (although it doesn't have to) as much as I can see. -- Tom. > > On 03/04/2015 11:26 AM, Yakov Goldberg wrote: >> yakov pushed a commit to branch master. >> >> http://git.enlightenment.org/tools/erigo.git/commit/?id=554c595e68639a676bd7dae3a4c1ccace3135a35 >> >> commit 554c595e68639a676bd7dae3a4c1ccace3135a35 >> Author: Yakov Goldberg <yako...@samsung.com> >> Date: Wed Mar 4 18:25:40 2015 +0200 >> >> Eo: adapt code to follow eo_do new syntax - part 3 >> --- >> src/lib/ffi_abstraction.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/src/lib/ffi_abstraction.c b/src/lib/ffi_abstraction.c >> index 00e05b6..56b4374 100644 >> --- a/src/lib/ffi_abstraction.c >> +++ b/src/lib/ffi_abstraction.c >> @@ -152,6 +152,7 @@ _ffi_eo_do(const Gui_Session *session, const Gui_Widget >> *wdg, const Gui_Widget_P >> ffi_call(&cif, (void (*)()) func_pointer, &result, values); >> ret = EINA_TRUE; >> } >> + _eo_do_end(); >> } >> >> end: >> @@ -237,6 +238,7 @@ _ffi_eo_do_get(const Gui_Session *session, const >> Gui_Widget *wdg, const Gui_Widg >> ffi_call(&cif, (void (*)()) func_pointer, &result, values); >> ret = EINA_TRUE; >> } >> + _eo_do_end(); >> } >> >> /* For enum type default value will be int. We need to change it to >> string value of current enum. */ >> @@ -340,7 +342,7 @@ _ffi_eo_add(const Gui_Session *session, const Gui_Widget >> *wdg, Eo *parent_eo) >> if (_eo_do_start(_eoid_, NULL, EINA_FALSE, __FILE__, __FUNCTION__, >> __LINE__)) >> { >> func_pointer(); >> - _tmp_obj = eo_finalize(); >> + _tmp_obj = _eo_add_end(); >> } >> >> ret = _tmp_obj; >> @@ -427,6 +429,7 @@ _ffi_eo_do_content(const Gui_Session *session, const >> Gui_Widget *wdg, const Gui_ >> ffi_call(&cif, (void (*)()) func_pointer, &result, values); >> ret = EINA_TRUE; >> } >> + _eo_do_end(); >> } >> >> end: >> @@ -546,6 +549,7 @@ _ffi_eo_item_add(const Gui_Session *session, const >> Gui_Widget *wdg, const Item_C >> { >> ffi_call(&cif, (void (*)()) func_pointer, &ret_item, values); >> } >> + _eo_do_end(); >> } >> >> end: >> > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
