On 03/04/2015 01:09 PM, Tom Hacohen wrote:
> On 04/03/15 18:08, Christopher Michael wrote:
>> On 03/04/2015 12:34 PM, Tom Hacohen wrote:
>>> On 04/03/15 17:31, Christopher Michael wrote:
>>>> On 03/04/2015 12:20 PM, Tom Hacohen wrote:
>>>>> On 04/03/15 09:25, Tom Hacohen wrote:
>>>>>> Commit guidelines.
>>>>>>
>>>>>> Mike, when you review commits, make sure they conform to our commit
>>>>>> guidelines. In this case, the summary line. This is not a single
>>>>>> instance, I've seen others too.
>>>>>
>>>>>
>>>>> Oops, rereading this after comments from Chris on IRC, I forgot to
>>>>> mention what's wrong.
>>>>>
>>>>> The problem here is the lack of the "ecore drm:" prefix, i.e the module
>>>>> prefix.
>>>>>
>>>>
>>>> Yes. That's where the confusion happened. You said Summary and I was
>>>> looking at the "Summary" line...not the prefix line.
>>>
>>> It's damn phab... :|
>>>
>>> In git lingo the summary line is the first line of the commit ("subject").
>>>
>>
>> Can we just call it subject line then to avoid any further confusion ??
>> Seems more accurate a description anyway
>
> You'll then confuse the git guys. :)Well, if all 2 of you can't remember that, then you got issues :P > I'll try my best, when commenting on your patches to: > 1. Refer to it as a subject line (in addition to summary). And I'll try my best to review the commit message also ... I mainly just focus on the code > 2. Call you Chris and not Mike. :) I am sure Mike would appreciate that ;) > > > -- > Tom. > > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
