On 16/03/15 17:07, Yakov Goldberg wrote: > Hi, > > I have an issue with Elm_Button (and other classes which inherit from > Elm_Layout) and efl_file_set/get(). > ERR<22924>:eo lib/eo/eo.c:676 _eo_call_resolve() in > ../src/lib/efl/interfaces/efl_file.eo.c:2: func 'efl_file_get' (613) > could not be resolved for class 'Elm_Button'. > > I don't know if there is any sense to call "efl_file_set/get" on Button, > that's just what I see in Erigo when fetch all inheritance classes and > functions for "Elm_Button". > I think we have inheritance problem here. > > The thing is that "Elm_Layout" inherits from "Efl.File" interface and > implements only "file_set". > "File" property is virtual pure so according to logic both: "file_set" > and "file_get" must be implemented, but "file_get" is not. > > The question is: why was not "file_get" implemented in "Elm_Layout"? > Intentionally or not? > Can I implement it in Elm_Layout? > Or maybe I need to implement it in "Elm_Button" and each other class > that inherits from Elm_Layout? But it seems wrong. > > If I implement it in ELm_Layout, I'll also have to fix (implement) > "file_get" in classes, which inherit from "Elm_Layout" but implement > only "file_set" (Currently I found only one: Elm_VIdeo). > > What do you think?
Let's separate the two issues at hand. 1. Elm layout's lack of file_get 2. Erigo not dealing with it properly For #1: it possibly should be added, I guess no one added it because no one cared (and tbh, it's not useful). Dunno and don't really care. Does layout have it's own file_get? If so, it's just an oversight. For #2: you should properly handle it in Erigo, there's no way around it. Having just set and no get is something that can happen. Having just get and not set (read only) is also a valid case. You should handle all. -- Tom. ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
