On 17/04/15 14:38, Carsten Haitzler wrote: > On Fri, 17 Apr 2015 11:46:59 +0100 Tom Hacohen <[email protected]> said: > >> On 17/04/15 11:22, Carsten Haitzler wrote:> On Fri, 17 Apr 2015 08:20:05 >> +0100 Tom Hacohen <[email protected]> said: >> > >> >> On 17/04/15 08:18, ChunEon Park wrote: >> >>> Poor description. >> >>> >> >>> Rather than excuse, >> >>> Please describe what does user suppose to do with this API. >> >> >> >> Are you talking to me or Mike? >> >> >> >> Anyhow, even when explained, this is an internal hacky API (if the >> >> comment is really true), and should not be exposed like this. >> > >> > totally agree - if people are now getting wayland window id for then >> going >> > direct to wl with it - STOP NOW. we have enough of this with x11 >> window id's. >> > CEASE. add a proper abstraction or say "we can't do it - go away". >> stop hacking >> > around it. it is a rare day you need to do this (one rare use is e >> itself with >> > its own internal windows - very very very rare as it's inside the >> compositor) >> > >> >> So what's the plan of action? Should I hide this method behind an ifdef >> for now? >> >> I'm also concerned about other such functions that may have crept in. >> Mike, do any others come into mind? > > perhaps... remove all documentation from them other than "never use this > function - internal use only" > >
I don't think removing docs is good enough. Also, internal functions should be documented too. If there are no objections, I'll ifdef it behind ELM_INTERNAL, or maybe ELM_INTERNAL. What do you think? -- Tom. ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
