On Tue, Jun 23, 2015 at 5:16 PM, Mike Blumenkrantz <[email protected]> wrote: > It would be great if, in the future, you could refrain from reverts like > this. An ongoing mailing list discussion was taking place, and, regardless > of what you feel "should never be done", now the issue is once again > unsolved.
In my experience if a bad solution is left in the tree for too long, it'll remain there forever, thus I choose to revert it now. This is one of the most awful pieces of code I've seen in the EFL yet and I couldn't sleep at night if it was left in, so at least this allows me to have a peace of mind; the issue was never really "solved" in the first place anyway - touching internal symbols within libraries is a big no (I'm sure most of other developers here will agree with my statement) and I would appreciate if you discussed things like this on the ML before actually introducing them. Regards, D5 > > On Tue, Jun 23, 2015 at 5:22 AM, Daniel Kolesa <[email protected]> wrote: > >> q66 pushed a commit to branch master. >> >> >> http://git.enlightenment.org/core/efl.git/commit/?id=d9db8888ac51175e350853597b3b317e9774a00a >> >> commit d9db8888ac51175e350853597b3b317e9774a00a >> Author: Daniel Kolesa <[email protected]> >> Date: Tue Jun 23 10:22:36 2015 +0100 >> >> Revert "edje: unset efreet cache update flag to prevent dbus >> connections" >> >> This reverts commit 1edb35fff3fe54ac7eea1ba2c26e509284b4e470. >> >> Accessing symbols from other libs like this should never be done. The >> consequences of this are not significant enough to do this; better >> solution >> can be found but definitely not like this. >> --- >> src/lib/edje/edje_main.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/src/lib/edje/edje_main.c b/src/lib/edje/edje_main.c >> index a891ec5..03c46ea 100644 >> --- a/src/lib/edje/edje_main.c >> +++ b/src/lib/edje/edje_main.c >> @@ -1,6 +1,5 @@ >> #include "edje_private.h" >> >> -extern int efreet_cache_update; >> static Edje_Version _version = { VMAJ, VMIN, VMIC, VREV }; >> EAPI Edje_Version * edje_version = &_version; >> >> @@ -70,7 +69,6 @@ edje_init(void) >> goto shutdown_eet; >> } >> >> - efreet_cache_update = 0; >> if (!efreet_init()) >> { >> ERR("Efreet init failed"); >> >> -- >> >> >> > ------------------------------------------------------------------------------ > Monitor 25 network devices or servers for free with OpManager! > OpManager is web-based network management software that monitors > network devices and physical & virtual servers, alerts via email & sms > for fault. Monitor 25 devices for free with no restriction. Download now > http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
