Hello. On 29/06/15 07:32, Amitesh Singh wrote: > ami pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id=1a1aaec3c9f58c4a7408ccfc3e8a14cc607cfb58 > > commit 1a1aaec3c9f58c4a7408ccfc3e8a14cc607cfb58 > Author: Amitesh Singh <amitesh...@samsung.com> > Date: Mon Jun 29 10:57:40 2015 +0530 > > Revert "theme: return false if elm_object_style_set() failed to set > requested style." > > This reverts commit 76004dfbec84664e253babc5bf576398a5901395. > > We need to change other code also to accommodate this change. > _elm_theme_set should return an enum which tells what failed. > enum { > THEME_APPLY_FAILED, > THEME_DEFAULT_SUCCESS. > THEME_APPLY_SUCCESS > }; > > Based on that, we decide what needs to be done. > The above code will break the layout theme if incorrect theme are passed. > It should be backported to Elm 1.14. >
With full commit access this backport is something you can do yourself. :) You are in the best position to decide if this patch needs to get into the 1.14 stable updates and you are in the best position to fix it as you already did for master. Normally this means nothing else besides checking out the efl-1.14 branch, cherry-pick the commit id followed by compile and run time testing. regards Stefan Schmidt ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
