Really, I don't like to a remove API's, but they have not body. Stub function as implementation - we can do it, but it's smell as an attempt to revive the corpse. I would not have left this API's, but If some one say that they need and should stay, I revert commit and make new, where it marked as deprecated and have a some stub.
On Fri, Sep 18, 2015 at 11:13 AM, Stefan Schmidt <ste...@osg.samsung.com> wrote: > Hello. > > On 17/09/15 19:34, Davide Andreoli wrote: > > Indeed they can be deleted, this is probably a leftover from when > gradients > > were removed from edje (years ago). > > > > Edje_Edit gradients API was working, and was removed when gradients was > > removed from edje. > > Which would have been comit b49c2411bdc7225be249124b2de5f48e5d4be161 > > They also have been removed from evas a month later (both in 2010). Our > Evas and Edje 1.0 releases have been in 2011. Which means the feature > itself was never part of our releases but we still had a public API for > 5 years which did not work. Wow, I really hope I got this wrong somehow. :/ > > In general I would just say no to a removal of released API symbols. In > this case the fact that the feature was removed 5 years ago and we have > no actual code implementing it is convincing to me. Especially as the > alternatives are not really flying as well a) bring back gradient or b) > mark them as deprecated which does not solve the problem that we have no > implementations. > > Having stub function as implementation which simply error out could be > ok if we want to really go the deprecation route. I see not much use in > it though. > > What do others think here? > > Cedric, as you removed the gradient feature at that time and now > introducing ector, which might have a use for gradients, I look for your > opinion here. > > regards > Stefan Schmidt > > > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
