Hello. On 20/10/15 11:24, Lukasz Stanislawski wrote: > On 10/20/2015 10:46 AM, Stefan Schmidt wrote: >> Hello. >> >> On 19/10/15 17:34, Lukasz Stanislawski wrote: >>> stanluk pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/elementary.git/commit/?id=15171f47d7e74afdd1f621d0c22e7375a2c14ab0 >>> >>> commit 15171f47d7e74afdd1f621d0c22e7375a2c14ab0 >>> Author: Lukasz Stanislawski <l.stanisl...@samsung.com> >>> Date: Fri Oct 9 16:17:52 2015 +0200 >>> >>> atspi: always update cache >>> >>> libatspi implementation allows to call methods on objects which >>> are not added to client cache with "AddAccessible" at-spi signal. >>> Bridge should allow to perform such calls by updating its internal >>> cache as soons as it returns a reference to the dbus object to >>> client. >> This does not look like a fix to me at all. Does it fix anything you did >> not mention here? >> New features should be left for the merge window. > I consider it more a fix then a feature. > When bridge returns a dbus path to some object it should be instantly > accessible to at-spi dbus clients. Previously it wasn't, so calls on > returned references could result in "invalid object" error if the > "added" event was not emitted by object beforehand. > So this patch basically removes some race condition that could happen > (but due to dbus latency it never had). > I will really like to have it in on 1.16...
Fair enough. With your explanation it really goes through as a fix. From your initial commit message it sounded more like a performance improvement by using caching. >> There is also a Coverity defect in atspi in elm which I mentioned in my >> 1.16 work item emails. I would be happy if you could give it a look. >> CID 1325724 Bad bit shift operation >> <https://scan6.coverity.com/docs/en/cov_checker_ref.html#static_checker_BAD_SHIFT> > Ok, I'll check it. Thanks! regards Stefan Schmidt ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
