Hi, On 25 November 2015 at 20:01, Tom Hacohen <t...@osg.samsung.com> wrote:
> I wonder why textgrid was affected and textblock wasn't. Maybe it's just > a bug with bitmap fonts? > > Looking at the harfbuzz commit you mentioned, I don't see how that would > matter at all. Are you sure that's the one? > Thanks for looking at this after me. The issue is "kinda" solved now, as it seems this comes from a bad commit in harfbuzz, and they will fix it. Hopefully our users won't be installing any buggy version (1.1.0 or 1.1.1) after we revert my patch (we should ^^) For reference: https://phab.enlightenment.org/T2865 https://github.com/behdad/harfbuzz/issues/187 > On 25/11/15 07:47, Jean-Philippe ANDRÉ wrote: > > jpeg pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=8ccea8233c144f723470da09a01487484c269440 > > > > commit 8ccea8233c144f723470da09a01487484c269440 > > Author: Jean-Philippe Andre <jp.an...@samsung.com> > > Date: Wed Nov 25 15:42:29 2015 +0900 > > > > Evas: Temporarily hack OT_SUPPORT to fix textgrid > > > > See T2865. > > Since Harfbuzz 1.1.0, terminology displays fonts funnily aligned to > > the top. This is apparently because until 1.0.6 the y_offset was > > always 0 for all glyphs, but since 1.1.1 the offset is actually > > set. > > > > This is a TEMPORARY fix. There might be an underlying issue left > > here. > > > > Harfbuzz changed behaviour in this commit: > > > > commit 44f82750807475aa5b16099ccccd917d488df703 > > Author: Behdad Esfahbod <beh...@behdad.org> > > Date: Wed Nov 4 20:40:05 2015 -0800 > > > > [ft] Remove font funcs that do nothing > > --- > > src/lib/evas/common/evas_font_ot.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/lib/evas/common/evas_font_ot.c > b/src/lib/evas/common/evas_font_ot.c > > index a5fe5b2..f24009e 100644 > > --- a/src/lib/evas/common/evas_font_ot.c > > +++ b/src/lib/evas/common/evas_font_ot.c > > @@ -318,7 +318,7 @@ evas_common_font_ot_populate_text_props(const > Eina_Unicode *text, > > Evas_Coord adv; > > ot_itr->source_cluster = infos->cluster; > > ot_itr->x_offset = positions->x_offset; > > - ot_itr->y_offset = positions->y_offset; > > + ot_itr->y_offset = 0; // FIXME positions->y_offset; FIXME// > > gl_itr->index = infos->codepoint; > > adv = positions->x_advance; > > > > > > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple > OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Jean-Philippe André ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
