Seoz, as the e developer, i asking about the risky code. Read my first mail. "i'm sure he already asked." is this guessing? I just let you know the fact since you argue it's necessary to ask raster, all of sudden. Even i didn't see eye to eye with you that point. Why it needs to ask raster? raster didn't write that code. :( Regards, Hermet -----Original Message----- From: "Daniel Juyung Seo"<seojuyu...@gmail.com> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: <jae_hyun....@samsung.com>; "Carsten Haitzler"<ras...@rasterman.com>; Sent: 2015-12-29 (ν) 17:27:21 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: Remove unnecessary layer set for elm_win. Hi hermet
> I didn't guess anything here nor agree both jaehyun and amitesh. This is because you said "i'm sure he already asked." Just saying "i'm sure" does not guarantee that Jaehyun actually discussed this with raster. The best way to communicate is to bring jaehyun in this talk instead of speaking on behalf of him. Why isn't he responsive? Maybe on a vacation? I think you guys sit very close so you can easily ping him if he is on site. > just leaving those risky code without any reasons doesn't make sense to me either. > In point of my view, if the code is incorrect and it disturbs improvement then we definitely try to improve it. I absolutely agree with this. I think you already know my point but repeating my self: To remove this kind of ancient and influential code, it's better to discuss with the original author first as he is alive and responsive. The thing jaehyun missed was 1. he didn't mention about that in the commit message and 2. he didn't responsive to the feedback of his commit. We're talking about the basics of cooperation. No one needs to be blamed. Thanks, Daniel Juyung Seo (SeoZ) On Tue, Dec 29, 2015 at 4:18 PM, Hermet Park <her...@naver.com> wrote: > I'm sorry but i have no idea about your point here Seoz. > I didn't guess anything here nor agree both jaehyun and amitesh. > But the code in win looked strange to me. > > But now, the point i want argue you here is, > just leaving those risky code without any reasons doesn't make sense to me either. > In point of my view, if the code is incorrect and it disturbs improvement then we definitely try to improve it. > > > Here the point is, > jaehyun needs prove that patch doesn't cause any side effects. otherwise, the patch seems be good to efl. > > > Regards, Hermet > > -----Original Message----- > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > To: "Carsten Haitzler"<ras...@rasterman.com>; "Amitesh Singh"<singh.amit...@gmail.com>; > Cc: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; <jae_hyun....@samsung.com>; > Sent: 2015-12-29 (ν) 15:28:41 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: Remove unnecessary layer set for elm_win. > > +Amitesh > > Thanks raster. > Problem solved. > > Daniel Juyung Seo (SeoZ) > > > On Tue, Dec 29, 2015 at 3:17 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > > On Tue, 29 Dec 2015 15:00:40 +0900 Daniel Juyung Seo <seojuyu...@gmail.com> > > said: > > > >> +Jaehyun > >> > >> OK let's stop guessing by ourselves and just ask Jaehyun and Raster. > >> Daniel Juyung Seo (SeoZ) > > > > i did tell jaehyun that i have no idea why that is there and it likely shouldnt > > be. its too long ago as to remember why its there as it was there in the > > initial elm win code. > > > >> On Tue, Dec 29, 2015 at 9:41 AM, Hermet Park <her...@naver.com> wrote: > >> > i'm sure he already asked. > >> > > >> > Regards, Hermet > >> > > >> > -----Original Message----- > >> > From: "Daniel Juyung Seo"<seojuyu...@gmail.com> > >> > To: "Enlightenment developer > >> > list"<enlightenment-devel@lists.sourceforge.net>; Cc: "Carsten > >> > Haitzler"<ras...@rasterman.com>; Sent: 2015-12-28 (μ) 15:58:15 > >> > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: > >> > Remove unnecessary layer set for elm_win. > >> > > >> > This code was there for years and it could impact the behavior. > >> > I think there must be a good reason for this code but I also have a > >> > doubt on this code. > >> > > >> > One thing I am sure is that if someone would like to change the code > >> > like this(been there for ages and could give an impact), it should be > >> > discussed with the original author(in this case, Raster) first as far > >> > as he/she is reachable. Do not just remove the code just because you > >> > don't know why. > >> > > >> > Of course, this could be a workaround code and needs to be removed but > >> > anyways ask raster first. I think there must be a reason. > >> > > >> > Thanks, > >> > Daniel Juyung Seo (SeoZ) > >> > > >> > > >> > On Mon, Dec 28, 2015 at 2:44 PM, Hermet <her...@naver.com> wrote: > >> >> If it doesn't cause any critical side effects/compatibility issues, I > >> >> can't see any reasons to keep it in. > >> >> > >> >> No one expects window layer value is 50. > >> >> But I'd rather ask why 50? why it should have layer 50? > >> >> > >> >> Specifically, evas_object_layer_set() API has been exposed, > >> >> which means the layer setting is up to users, even window object can be > >> >> dealt with the API by users. > >> >> > >> >> Additionally, window object was special one so it have been deal with > >> >> event stuff differently. > >> >> > >> >> > >> >> Regards, Hermet > >> >> > >> >> -----Original Message----- > >> >> From: "Amitesh Singh"<singh.amit...@gmail.com> > >> >> To: "Enlightenment developer > >> >> list"<enlightenment-devel@lists.sourceforge.net>; Cc: "Carsten > >> >> Haitzler"<ras...@rasterman.com>; Sent: 2015-12-25 (κΈ) 16:05:50 > >> >> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_win: > >> >> Remove unnecessary layer set for elm_win. > >> >> > >> >> Hello > >> >> > >> >> On Dec 18, 2015 3:54 PM, "Jaehyun Cho" <jae_hyun....@samsung.com> wrote: > >> >>> > >> >>> jaehyun pushed a commit to branch master. > >> >>> > >> >>> > >> >> http://git.enlightenment.org/core/elementary.git/commit/?id=a9be1d488daf74d11181909fb6c454991272fe1e > >> >>> > >> >>> commit a9be1d488daf74d11181909fb6c454991272fe1e > >> >>> Author: Jaehyun Cho <jae_hyun....@samsung.com> > >> >>> Date: Fri Dec 18 19:18:51 2015 +0900 > >> >>> > >> >>> elm_win: Remove unnecessary layer set for elm_win. > >> >>> --- > >> >>> src/lib/elm_win.c 1 - > >> >>> 1 file changed, 1 deletion(-) > >> >>> > >> >>> diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c > >> >>> index b1a05ae..f509f95 100644 > >> >>> --- a/src/lib/elm_win.c > >> >>> +++ b/src/lib/elm_win.c > >> >>> @@ -3830,7 +3830,6 @@ _elm_win_finalize_internal(Eo *obj, Elm_Win_Data > >> >> *sd, const char *name, Elm_Win_ > >> >>> evas_object_color_set(obj, 0, 0, 0, 0); > >> >>> evas_object_move(obj, 0, 0); > >> >>> evas_object_resize(obj, 1, 1); > >> >>> - evas_object_layer_set(obj, 50); > >> >> > >> >> I wonder why it was removed. As far as I know, elm win is a fake ecore > >> >> evas object. Basically it's just a wrapper of ecore evas and since elm win > >> >> does not contain any object so I think it's better to put it at layer 50. > >> >> After this change, there could be a case when it does not receive any > >> >> events as it might go at lowest at layer 0. This could result into some > >> >> side effects. Please consider this. > >> >>> evas_object_pass_events_set(obj, EINA_TRUE); > >> >>> > >> >>> if (type == ELM_WIN_INLINED_IMAGE) > >> >>> > >> >>> -- > >> >>> > >> >>> > >> >> ------------------------------------------------------------------------------ > >> >> _______________________________________________ > >> >> enlightenment-devel mailing list > >> >> enlightenment-devel@lists.sourceforge.net > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> >> ------------------------------------------------------------------------------ > >> >> _______________________________________________ > >> >> enlightenment-devel mailing list > >> >> enlightenment-devel@lists.sourceforge.net > >> >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > >> > ------------------------------------------------------------------------------ > >> > _______________________________________________ > >> > enlightenment-devel mailing list > >> > enlightenment-devel@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > ------------------------------------------------------------------------------ > >> > _______________________________________________ > >> > enlightenment-devel mailing list > >> > enlightenment-devel@lists.sourceforge.net > >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
