Hello On 01/13/2016 05:36 PM, Mike Blumenkrantz wrote: > Hi, > > I realize that this is a project that you are working on, and that many > times you will have a lot of commits to push at once, but can you avoid > pushing commits that revert commits made in the same push? Not only does > this sort of behavior ruin your project's history with nonsense commits, > but it also creates more noise for anyone who is watching it. Mike, thanks for the comment. We are trying to follow the efl guidelines, but this time we be in a hurry and forgot add comment to revert commits.
Thanks. > Thanks! > > On Wed, Jan 13, 2016 at 9:53 AM Vitalii Vorobiov <vi.vorob...@samsung.com> > wrote: > >> rimmed pushed a commit to branch master. >> >> >> http://git.enlightenment.org/tools/eflete.git/commit/?id=3c59c66ca77e58fafc0cd3c8f853fb43c60bae0d >> >> commit 3c59c66ca77e58fafc0cd3c8f853fb43c60bae0d >> Author: Vitalii Vorobiov <vi.vorob...@samsung.com> >> Date: Wed Jan 13 14:41:04 2016 +0200 >> >> Revert "workspace: hide and show demo instead of deletion, to keep all >> set values" >> >> This reverts commit 59ac43c1672cddeec45e3eb161685fe8c89fcd26. >> >> Change-Id: I1d4c40010f77cb241cb7d9c3e9531fe43dfe6551 >> --- >> src/bin/ui/workspace/workspace.c | 6 ++---- >> 1 file changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/src/bin/ui/workspace/workspace.c >> b/src/bin/ui/workspace/workspace.c >> index a9d914f..3a4787d 100644 >> --- a/src/bin/ui/workspace/workspace.c >> +++ b/src/bin/ui/workspace/workspace.c >> @@ -951,7 +951,7 @@ _mode_changed(void *data, >> if ((sd->active_mode == MODE_NORMAL)/* || (sd->active_mode == >> MODE_SEPARATE) */) >> evas_object_hide(sd->groupedit); >> else >> - evas_object_hide(sd->active_mode_object); >> + evas_object_del(sd->active_mode_object); >> >> mode = elm_radio_state_value_get(obj); >> >> @@ -980,8 +980,7 @@ _mode_changed(void *data, >> workspace_separate_mode_set(sd->obj, false); >> container_border_show(sd->container.obj); >> >> - if (!sd->active_mode_object) >> - sd->active_mode_object = demo_add(sd->scroller, sd->group); >> + sd->active_mode_object = demo_add(sd->scroller, sd->group); >> evas_object_show(sd->active_mode_object); >> container_content_set(sd->container.obj, >> sd->active_mode_object); >> >> @@ -1267,7 +1266,6 @@ _workspace_smart_del(Evas_Object *o) >> evas_object_del(sd->highlight.highlight); >> demo_group_del(sd->demo_group); >> gm_group_edit_object_unload(sd->group); >> - evas_object_del(sd->active_mode_object); >> _workspace_parent_sc->del(o); >> } >> >> >> -- >> >> >> > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Viacheslav Reutskiy (rimmed) ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
