On Fri, Feb 5, 2016 at 9:34 PM Carsten Haitzler <ras...@rasterman.com>
wrote:

> raster pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=d0229b3652872b0324ec4671e7469d9a9904186b
>
> commit d0229b3652872b0324ec4671e7469d9a9904186b
> Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> Date:   Sat Feb 6 11:31:01 2016 +0900
>
>     e - restart window positioning - fix it
>
>     so every time i restart e i have my windows all messed up. it's
>     INSANELY annoying and time consuming every single time having to move
>     a dozen or more windows back to where they should be just because i
>     restarted e. i've narrowed it down to 2 places. 1 which is trying to
>     handle "out of screen" windows and during startup it seems things are
>     not quite stable yet as the randr code figures things out until the
>     event storm settles down.
>
>     when this is then fixed - another bit of code just shuffles windows up
>     all the time by a titlebar whcih is also supremely annoying. this is
>     the code that adopes a new frame for a window.
>
>     so the nasty hack to avoid piles of pain right now is for the first 5
>     seconds of e's life - don't do this stuff. at least you can now use e
>     and not be annoyed to hell and back every restart.
>
>     yes a nicer fix may be better - but that's going to take a lot more
>     time and patience and until then - this will do.
> ---
>  src/bin/e.h             |  1 +
>  src/bin/e_client.c      | 15 +++++++++++----
>  src/bin/e_comp_object.c | 11 +++++++++--
>  src/bin/e_main.c        |  2 ++
>  4 files changed, 23 insertions(+), 6 deletions(-)
>
>
I see you managed to find a couple bugs! Thanks for looking into this, I
was unaware that there were problems with the cases cited here. I've made
some followup commits which further address the issues.

There were some problematic results from this commit, so I've reverted it:
your change to frame recalc broke restart application positioning, and your
workaround for rescuing offscreen windows covered up a much more serious
bug related to useful zone geometry calc (which I caused).

Since I think we can both agree that there were some cases which your patch
didn't handle, and probably it's not the best use of your time to be
tracking those cases down, I'd like to propose that when you've found the
cause of an issue and don't have the time to fully fix it you just open a
ticket and attach your WIP patch to it. You can then run the patch locally
to resolve your issues while assigning the issue ticket to me so that I can
more extensively test various corner cases.
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to