On Wed, 24 Feb 2016 13:53:48 +0900 (KST) Hermet Park <her...@hermet.pe.kr> said:
> I think this changes edc grammar. > only one part may not need a part name. > and App edc will be broken after this patch. > > Do you really like it? i wrote edje_cc - i never intended or especterd people to NOt name parts. ihave NEVER written edc without naming a part. it's pretty much expected to be named because name is then used in signals - eg mouse in.out,down,up ans the source. the fact edje_cc didn't CHECK and tell you/abort/warn is indeed an oversight, but it was never INTENDED to be able to not name parts. you need the names to do inheritance or a swallows to as anything that is a src of a signal. on the other hand i do get hermet's point. maybe we can do a sleep(30); there with the warning - their stuff won't break but their compiles will slow down with a very noticeable warning there in the logs. later it can become a fatal error. > -----Original Message----- > From: "Viacheslav Reutskiy"<reutskiy....@gmail.com> > To: "Enlightenment developer > list"<enlightenment-devel@lists.sourceforge.net>; Cc: > Sent: 2016-02-23 (화) 18:13:30 > Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: edje_cc: abort compile > when unnamed part exists > Crap, I made a mistake. I made 'arc land' instead 'arc close-revision'. > How to fix it? Revert and push correctly? > > > On 02/23/2016 11:06 AM, Vyacheslav Reutskiy wrote: > > rimmed pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=81f8e8683d90435c6321e643d40047de643d5a58 > > > > commit 81f8e8683d90435c6321e643d40047de643d5a58 > > Author: Vyacheslav Reutskiy <v.reuts...@samsung.com> > > Date: Tue Feb 23 11:06:55 2016 +0200 > > > > edje_cc: abort compile when unnamed part exists > > > > Summary: abort compile when unnamed part exists. > > > > Reviewers: raster, reutskiy.v.v > > > > Reviewed By: reutskiy.v.v > > > > Subscribers: cedric, jpeg > > > > Differential Revision: https://phab.enlightenment.org/D3723 > > --- > > src/bin/edje/edje_cc_handlers.c 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/src/bin/edje/edje_cc_handlers.c > > b/src/bin/edje/edje_cc_handlers.c index 4ce5a86..fcaad2e 100644 > > --- a/src/bin/edje/edje_cc_handlers.c > > +++ b/src/bin/edje/edje_cc_handlers.c > > @@ -14647,6 +14647,11 @@ edje_cc_handlers_hierarchy_pop(void) > > { > > unsigned int i; > > > > + if (!current_part->name) > > + { > > + error_and_abort(NULL, "parse error near %s:%i. Unnamed part > > exists in Group \"%s\".", file_in, line - 1, current_de->entry); > > + } > > + > > for (i = 0; i < current_part->other.desc_count; i++) > > { > > if (!current_part->other.desc[i]->state.name) > > > > -- > Viacheslav Reutskiy (rimmed) > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
