It's been over a week with no reply and this is still broken after your revert. If there continues to be no compelling evidence supporting the revert, the patch will go back in next week.
On Tue, Mar 8, 2016 at 2:28 PM Mike Blumenkrantz < michael.blumenkra...@gmail.com> wrote: > Hi, > > I am confused by this. > > Here are some screenshots of the only ctxpopup test which looks different > between these commits. > This is how it looks with your revert: http://i.imgur.com/tlIdBDU.png > This is how it looked before the revert: http://i.imgur.com/RrT4iXL.png > > Unless the goal is for horizontal ctxpopup to be unusable, the second > (pre-revert) screenshot is clearly the correct one. > > I attempted to use enventor in order to see the issue you described there. > This is how enventor looks after a first install: > http://i.imgur.com/RNXh4Fy.png > I filed https://phab.enlightenment.org/T3281 for it. > > What is the bug here??? > > On Tue, Mar 8, 2016 at 11:27 AM Hermet Park <her...@hermet.pe.kr> wrote: > >> Hey, Mike I reverted your patch. >> Since this broke enventor auto completion feature as well as ctxpopup >> example in elementary_test. >> >> We need to figure them out before applying this patch. >> >> -----Original Message----- >> From: "Hermet Park"<her...@hermet.pe.kr> >> To: <g...@lists.enlightenment.org>; >> Cc: >> Sent: 2016-03-08 (화) 21:00:29 >> Subject: [EGIT] [core/elementary] master 01/01: Revert "list: set >> internal box as homogeneous if no separator items are present" >> >> hermet pushed a commit to branch master. >> >> >> http://git.enlightenment.org/core/elementary.git/commit/?id=89a2a7c134c8b5a9ab128c44db693c207bed55f3 >> >> commit 89a2a7c134c8b5a9ab128c44db693c207bed55f3 >> Author: Hermet Park <her...@hermet.pe.kr> >> Date: Tue Mar 8 20:58:17 2016 +0900 >> >> Revert "list: set internal box as homogeneous if no separator items >> are present" >> >> This reverts commit 9f4c43c20dfa36e7a8be18278acf4336c13574d7. >> >> I'm sorry but this causes a side effect(list sizing issue) at >> enventor. >> And I couldn't find any mis-usage in enventor side. >> >> We can't not accept this patch unless we figure the exact reason out. >> --- >> src/lib/elm_list.c 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/src/lib/elm_list.c b/src/lib/elm_list.c >> index 78c6804..14164dc 100644 >> --- a/src/lib/elm_list.c >> +++ b/src/lib/elm_list.c >> @@ -815,7 +815,6 @@ _items_fix(Evas_Object *obj) >> const char *it_plain; >> const char *it_compress; >> const char *it_compress_odd; >> - Eina_Bool separators = EINA_FALSE; >> >> ELM_LIST_DATA_GET(obj, sd); >> >> @@ -851,7 +850,6 @@ _items_fix(Evas_Object *obj) >> if (mw > minw[1]) minw[1] = mw; >> if (mh > minh[1]) minh[1] = mh; >> } >> - separators = it->is_separator; >> } >> >> if ((minw[0] != sd->minw[0]) (minw[1] != sd->minw[1]) >> @@ -865,7 +863,6 @@ _items_fix(Evas_Object *obj) >> } >> >> i = 0; >> - elm_box_homogeneous_set(sd->box, !separators); >> EINA_LIST_FOREACH(sd->items, l, eo_it) >> { >> ELM_LIST_ITEM_DATA_GET(eo_it, it); >> >> -- >> >> >> ------------------------------------------------------------------------------ >> Transform Data into Opportunity. >> Accelerate data analysis in your applications with >> Intel Data Analytics Acceleration Library. >> Click to learn more. >> http://makebettercode.com/inteldaal-eval >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
