Btw, this patch is incomplete. It doesn't mark the class get functions as weak.
On Sat, Apr 2, 2016 at 3:27 AM, Carsten Haitzler <[email protected]> wrote: > On Fri, 1 Apr 2016 17:20:36 +0100 Tom Hacohen <[email protected]> said: > > > On 01/04/16 17:09, Cedric BAIL wrote: > > > On Apr 1, 2016 3:53 AM, "Tom Hacohen" <[email protected]> wrote: > > >> > > >> On 01/04/16 04:09, Jean-Philippe ANDRÉ wrote: > > >>> jpeg pushed a commit to branch master. > > >>> > > >>> > > > > http://git.enlightenment.org/core/efl.git/commit/?id=78bb21a2d90bf7813632d19b87e0bac666eca6f8 > > >>> > > >>> commit 78bb21a2d90bf7813632d19b87e0bac666eca6f8 > > >>> Author: Jean-Philippe Andre <[email protected]> > > >>> Date: Thu Mar 31 14:19:08 2016 +0900 > > >>> > > >>> Eolian: Mark all EO class_get() as weak > > >>> > > >>> This follows the previous commit for the same reasons. > > >>> --- > > >>> src/bin/eolian/eo_generator.c | 2 +- > > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > > >>> > > >>> diff --git a/src/bin/eolian/eo_generator.c > > > b/src/bin/eolian/eo_generator.c > > >>> index a97f2f0..d718775 100644 > > >>> --- a/src/bin/eolian/eo_generator.c > > >>> +++ b/src/bin/eolian/eo_generator.c > > >>> @@ -53,7 +53,7 @@ static const char > > >>> tmpl_eo_obj_header[] = "\ > > >>> #define @#CLASS_@#CLASSTYPE @#klasstype_get()\n\ > > >>> \n\ > > >>> -EAPI const Eo_Class *@#klasstype_get(void);\n\ > > >>> +EWAPI const Eo_Class *@#klasstype_get(void);\n\ > > >>> \n\ > > >>> "; > > >>> > > >>> > > >> > > >> Why do it just for Eo API and not all of our API? > > > > > > Isn't it too late for our API as you can't rely on them being weak ? > Also I > > > wonder what the impact is on the ABI side in the case we do it for all > our > > > API. > > > > Too late for current but not for new, so making this be applied to all > > EAPI would make this automatic and less confusing. If we think this is a > > good idea, this should be available for all future APIs. You can't rely > > on existing to be weak, but you don't need to anyway, why does it matter? > > > > Not saying anything one way or the other, just pointing out the > > inconsistency. > > incentive to move to eo -> take advantage of weakness? :) > > > -- > > Tom. > > > > > > > ------------------------------------------------------------------------------ > > Transform Data into Opportunity. > > Accelerate data analysis in your applications with > > Intel Data Analytics Acceleration Library. > > Click to learn more. > > http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) [email protected] > > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
